Fix for flaky RedisCluster test in GitHub CI #2659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We often have to rerun the test suite on GitHub actions because of a hard to reproduce "Read error on connection" exception when getting a new `RedisCluster` instance. No one has ever reported this failure outside of GitHub CI and it's not clear exactly what might be going on. This commit does two main things: 1. Allows for one failure to construct a new `RedisCluster` instance but only if we detect we're running in GitHub CI. 2. Adds much more diagnostic information if we still have a fatal error (e.g. we can't connect in two tries, or some other fatal error happens). The new info includes the whole callstack before aborting as well as an attempt to manually ping the seeds with `redis-cli`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix a flaky test that only fails in GitHub CI and add more diagnostics when the tests fail with a fatal error.
Fix a float -> int truncation warning in our
HEXPIREtests.