Update xpending method to include idle-time parameter #2693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the xpending method in both redis.stub.php and redis_cluster.stub.php to add an optional idle-time parameter. This allows users to filter pending messages based on idle time, enhancing the functionality and flexibility of the method.
|
Thanks for the PR. We'll have to wait to merge this until putting together a major version bump since it changes the prototype which will break subclasses. |
|
You'll need to regenerate the arginfo files with You can do this by cd'ing into the phpredis source tree and then running it like this: php /usr/lib/php/20240924/build/gen_stub.php *.stub.phpIt may be on a slightly different place on your system so you can search for it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the xpending method in both redis.stub.php and redis_cluster.stub.php to add an optional idle-time parameter. This allows users to filter pending messages based on idle time, enhancing the functionality and flexibility of the method.