Source compatibility for compiling with VS 2008 on win32 #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Thanks a lot for this, I'll run the unit tests tonight to make sure that all still works and then merge it. |
|
Thanks for the quick response. If you have a windows box to test it, I have just uploaded a compiled binary here (saves the effort of compiling it): https://github.com/downloads/char101/phpredis/php_redis.dll (php 5.3.6, vs 2008, requires vc++ 2008 runtime, *session support not included, I can recompile it with session if required). |
|
Merged, thanks! |
|
Hi, Thanks a lot Nicolas :D |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
So this is my 2nd pull request, the first one is to owclient. Would you like to merge this changes so that it's easier to compile phpredis on windows?
Here's the summary of the changes
Thanks.