Refactor: Use RedisCmd for more cluster commands#2876
Merged
Conversation
Introduce `cluster_send_command_rcmd` and `cluster_send_command_rcmd_ex` that simplifies calling logic that is currently repeatedly extracting the command and length anywy. Additionally this lets us elide key prefixing and conditional freeing of the duplicate string at the callsites. Signed-off-by: michael-grunder <[email protected]>
| const char *cmd, int cmd_len); | ||
|
|
||
| static zend_always_inline short | ||
| cluster_send_cmd_rcmd(redisCluster *c, RedisCmd *cmd) |
Member
There was a problem hiding this comment.
Should it be named like cluster_send_rcmd or cluster_send_rcommand?
Member
Author
There was a problem hiding this comment.
Both are better. I couldn't think of what to name it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
cluster_send_command_rcmdandcluster_send_command_rcmd_exthat simplifies calling logic that is currently repeatedly extracting the command and length anywy.Additionally this lets us elide key prefixing and conditional freeing of the duplicate string at the callsites.