Fix bug of unclosed socket stream in RedisCluster's construction #774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi, |
|
I haven't. I'm curious, does that even work? I know a while back there was a debate as to whether to support authentication in a cluster at all. I suppose I'll spin one up and see. That being said, if people are doing this it isn't difficult from my side as I just have to send a command. It would have to be sent to me beforehand, and wouldn't be able to handle lots of different passwords per node, etc. So like a master 'password' could be set up but that would be to all nodes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The socket stream in RedisCluster.seeds leave unclosed incorrectly.
Which cause crash when creating RedisCluster repeatedly，even if call close function in the loop.
And the error message show "Couldn't map cluster keyspace using any provided seed"