php7 - Properly add igbinary to the include path in windows #917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, building 32-bit with igbinary enabled in Visual Studio 2015 failed, since igbinary/igbinary.h wasn't in the include path (VS2015 x86 Native Tools command prompt) Pecls were installed in a pecl folder adjacent to (same level as) php-7.0.9-src folder. ``` C:\php-sdk\bin\phpsdk_setvars.bat buildconf configure --disable-all --enable-cgi --enable-session --enable-igbinary --enable-redis-igbinary ```
This was referenced Aug 7, 2016
|
@TysonAndre, do you know any service like Travis CI for Windows? |
|
@yatsukhnenko https://www.appveyor.com/ , though I haven't used it in any of my own projects
https://github.com/phalcon/zephir/blob/master/appveyor.yml is an example of a project using Appveyor |
|
https://github.com/igbinary/igbinary/blob/master/WINDOWS.md also mentions how to build with Windows in a VM locally (Haven't done that in over a month, but should still be current) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, building 32-bit with igbinary enabled in
Visual Studio 2015 failed,
since igbinary/igbinary.h wasn't in the include path
(VS2015 x86 Native Tools command prompt)
CHECK_HEADER_ADD_INCLUDE would add pecl/phpredis/../igbinary to the include path. Then, it would search for pecl/phpredis/../igbinary/igbinary/igbinary.h (etc), which didn't exist when I built it. (pecl/phpredis/../igbinary/igbinary.h does)
Pecls were installed in a pecl folder adjacent to (same level as)
php-7.0.9-src folder.
The commit in this PR can be cherry-picked to develop as well, since the config.w32 has the same bug.