Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

phux
Copy link

@phux phux commented Apr 21, 2017

Q A
Branch 0.11.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Documented? no
Fixed tickets #339

The hook templates contain a duplicated exec because there is already exec defined in the HOOK_COMMAND.

@voidtek
Copy link

voidtek commented Apr 21, 2017

I applied this patch on two machines, the first one have this issue and the second one works perfectly without this patch.
After applying this patch, these two machines work now perfectly, the issue mentioned doesn't occur and we have not regression bugs.

Thanks for your job.

@veewee
Copy link
Contributor

veewee commented Apr 22, 2017

Thanks for the PR!

I would rather deal with the source of the issue instead of removing the exec from the hook template since it is there for a reason.
Can you give me some additional information about systems that are adding those second "exec" statement? (OS, PHP version, composer show, ...) I was not able to reproduce.

It looks like this additional exec is added by the Symfony Process component here in this PR: symfony/symfony#21474
This issue mentions the break: symfony/symfony#22476
And a PR is on it's way: symfony/symfony#22476

So I am not sure this is something that needs to be fixed in this repo.

@veewee veewee added the bug label Apr 22, 2017
@phux
Copy link
Author

phux commented Apr 22, 2017

You're right, it's due to my symfony/process version which is the mentioned 3.3 :)
And you're right, it's not the responsibility of this repo to fix it.

I am fine with closing this PR. I will just use my fork until process is fixed.

@veewee
Copy link
Contributor

veewee commented Apr 22, 2017

Alright, I'll close this one.
You could also copy the adjusted hook templates to your project and use the hooks_dir parameter (https://github.com/phpro/grumphp/blob/master/doc/parameters.md) . This way you don't have to maintain your own patch.

@veewee veewee added the invalid label Apr 22, 2017
@veewee veewee closed this Apr 22, 2017
@phux
Copy link
Author

phux commented Apr 22, 2017

@veewee even better. Thanks for mentioning it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants