Fix symfony progressbar issues #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also dropped HHVM support in this ticket since I retrieve following Travis error: Support for HHVM is also dropped by other package like Symfony and Doctrine because of compatibility issues with PHP 7. It looks like a good idea to drop support for HHVM in this package as well. More information: https://symfony.com/blog/symfony-4-end-of-hhvm-support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony 3.3.0 makes the ProgressBar final. This causes all mocked ProgressBar objects to crash in phpspec.
Additional info: symfony/symfony#20487