style: fix cs and type in SSH2::get_stream_timeout()
#2016
Conversation
There was a problem hiding this comment.
I don't know how I missed this - I apologize!
I mean, on July 12 I flew from Texas to Tokyo on vacation. You submitted this PR on July 9. So that prob had something to do with it. But I feel like I could have reviewed it on either July 10 or July 11 meh.
Anyway, I did fix most of these issues with 44d5ca2 . You and I implemented different fixes for one issue (which is causing a merge conflict) and one of the changes I strongly disagree with, as my comment elaborates upon.
a656aa9 to
28094ae
Compare
| ->setFinder(PhpCsFixer\Finder::create() | ||
| ->in(__DIR__ . '/..') | ||
| // https://github.com/phpseclib/phpseclib/pull/2016#discussion_r1691282898 | ||
| ->notPath('phpseclib/Crypt/Blowfish.php')) |
There was a problem hiding this comment.
I think we should ignore it for now.
There was a problem hiding this comment.
tbh if we're going to be ignoring files I think it'd better just to drop PhpCsFixer all together.
In reviewing how PhpCsFixer came to be included in phpseclib... so there was #1748 for the master branch that I cherry-picked into the 3.0 branch. Then there was #1754 but it ultimately wasn't merged because of whitespace issues similar to what we're dealing with, now. I proposed codesniffer be used instead and then we got #1760. So right now we're doing PhpCsFixer, codesniffer and pslam. Maybe we jut do codesniffer and pslam.
It'd be a shame to lose codesniffer because it does make good finds but I greatly dislike the idea of excluding entire files and of making the types of whitespace changes that it's proposing.
I suppose another idea would be to take the output of PhpCSFixer and filter out errors from lines of code that have // @codingStandardsIgnoreStart before it and // @codingStandardsIgnoreEnd after.
There was a problem hiding this comment.
I use (and contribute to) https://github.com/doctrine/coding-standard. Can consider to switch to that.
SSH2::get_stream_timeout()
No description provided.