Prevent loops during disconnect #2031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… disconnecting. Do not attempt disconnect packet send on closed socket.
|
Looks good to me! I'll merge it this weekend - thanks! |
|
We've also hit this problem. Can you say when a new release is to be expected? |
|
I can try to do a new release this weekend!
…On Tue, Sep 10, 2024, 9:23 AM Ivan Wolf ***@***.***> wrote:
We've also hit this problem.
Thanks for solving it, @terrafrost <https://github.com/terrafrost> 🙌
Can you say when a new release is to be expected?
—
Reply to this email directly, view it on GitHub
<#2031 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABULSWEHRPUGOWZHGQKQSLZV36F7AVCNFSM6AAAAABMQPYPB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBQHE4DCMBVGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
3.0.42 has been released: |
|
Thanks a lot, @terrafrost! I can confirm that the change fixed our problem 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to address #2030 where it was reported the potential to enter an infinite loop while disconnecting, seemingly due to an absent check for a closed/eof socket prior to issuing a final DISCONNECT message. This change prevents sending said DISCONNECT message on a closed socket, and also adds further protection for looping for other possible error paths.