Update Larastan#14024
Merged
Merged
Conversation
Member
|
Thank you very much! |
Contributor
|
@canvural thanks for the heads up. could you reference a commit which is relevant so we can see how much the PR broke BC and whether we need todo something about that? |
Contributor
Author
No it wasn't PR's fault. I had a custom type which has generic types but I was extending |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
phpstan/phpstan-src#4818 broke the Larastan. I fixed it today. This PR updates the commit in integration tests. I check occasionally if a new PR/commit breaks Larastan 😄 So it's good to have a green check to distinguish.