Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update pocketmine-ng-baseline.neon#14611

Closed
staabm wants to merge 1 commit into
phpstan:2.1.xfrom
staabm:pmmp
Closed

Update pocketmine-ng-baseline.neon#14611
staabm wants to merge 1 commit into
phpstan:2.1.xfrom
staabm:pmmp

Conversation

@staabm
Copy link
Copy Markdown
Contributor

@staabm staabm commented May 14, 2026

the PMMP build needs to be green so the "regenerate baseline" job is working again

@staabm
Copy link
Copy Markdown
Contributor Author

staabm commented May 14, 2026

@VincentLanglet you double checked these new errors already and they are valid, right?

@staabm staabm requested a review from VincentLanglet May 14, 2026 08:28
VincentLanglet
VincentLanglet previously approved these changes May 14, 2026
@VincentLanglet
Copy link
Copy Markdown
Contributor

I checked phpstan/phpstan-src#5649 but this wasn't in the list

path: repo/tools/generate-item-upgrade-schema.php

-
message: '#^Casting to list\<string\> something that''s already list\<string\>\.$#'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +184 to +193
message: '#^Offset 0\|1 might not exist on non\-empty\-array\{1\?\: \*NEVER\*, 0\?\: \*NEVER\*\}\.$#'
identifier: offsetAccess.notFound
count: 1
path: repo/src/data/bedrock/item/ItemSerializerDeserializerRegistrar.php

-
message: '#^Offset 0\|1\|2\|3 might not exist on non\-empty\-array\{0\?\: non\-empty\-array\{1\?\: \*NEVER\*, 0\?\: \*NEVER\*\}, 1\?\: non\-empty\-array\{1\?\: \*NEVER\*, 0\?\: \*NEVER\*\}, 2\?\: non\-empty\-array\{1\?\: \*NEVER\*, 0\?\: \*NEVER\*\}, 3\?\: non\-empty\-array\{1\?\: \*NEVER\*, 0\?\: \*NEVER\*\}\}\.$#'
identifier: offsetAccess.notFound
count: 1
path: repo/src/data/bedrock/item/ItemSerializerDeserializerRegistrar.php
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure where come from the error
https://github.com/pmmp/PocketMine-MP/blob/stable/src/data/bedrock/item/ItemSerializerDeserializerRegistrar.php

But looking at the shape of the array the error make sens.
I just dunno why it say *NEVER* everywhere... That's an error we had in another baseline I think

@VincentLanglet
Copy link
Copy Markdown
Contributor

I think the entries are already in the baseline and there is nothing to change

@staabm staabm closed this May 18, 2026
@staabm staabm deleted the pmmp branch May 18, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants