Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix infer new templated type from initial assign into static property #3364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 10 commits into from
Sep 18, 2024
Merged

Fix infer new templated type from initial assign into static property #3364

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fd78097
DEBUG local debug
mvorisek Aug 21, 2024
5e7b7d0
copy test
mvorisek Aug 27, 2024
92342eb
integrate test
mvorisek Aug 27, 2024
0cf4239
adjust copied test for static testing - issue 5551
mvorisek Aug 27, 2024
4a1ff4e
fix
mvorisek Aug 27, 2024
a4c1d8c
Revert "DEBUG local debug"
mvorisek Aug 27, 2024
ea87672
add 10686 test
mvorisek Aug 27, 2024
6e50e88
add 5551 test
mvorisek Aug 27, 2024
b80fdd5
Revert "add 5551 test" - does not emit an error
mvorisek Aug 27, 2024
19c2156
fix test lint
mvorisek Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add 10686 test
  • Loading branch information
@mvorisek
mvorisek committed Aug 27, 2024
commit ea8767227a5038ce3d7083455100042c0fab2ac0
5 changes: 5 additions & 0 deletions tests/PHPStan/Rules/Properties/TypesAssignedToPropertiesRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,6 +637,11 @@ public function testGenericsInCallableInConstructor(): void
$this->analyse([__DIR__ . '/data/generics-in-callable-in-constructor.php'], []);
}

public function testBug10686(): void
{
$this->analyse([__DIR__ . '/data/bug-10686.php'], []);
}

public function testBug11275(): void
{
if (PHP_VERSION_ID < 80000) {
Expand Down
33 changes: 33 additions & 0 deletions tests/PHPStan/Rules/Properties/data/bug-10686.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
<?php

namespace Bug10686;

class Model {}

/**
* @template T of object|array<mixed>
*/
class WeakAnalysingMap
{
/** @var list<T> */
public array $values = [];
}

class Reference
{
/** @var WeakAnalysingMap<Model> */
private static WeakAnalysingMap $analysingTheirModelMap;

public function createAnalysingTheirModel(): Model
{
if ((self::$analysingTheirModelMap ?? null) === null) {
self::$analysingTheirModelMap = new WeakAnalysingMap();
}

$theirModel = new Model();

self::$analysingTheirModelMap->values[] = $theirModel;

return end(self::$analysingTheirModelMap->values);
}
}