Add non regression test for 3506#4173
Merged
Merged
Conversation
Member
|
Thank you! |
phpstan-bot
added a commit
to phpstan-bot/phpstan-src
that referenced
this pull request
Mar 31, 2026
Restore preserveVacuousConditionals from PR phpstan#5056 and add a targeted guard overlap check in createConditionalExpressions() to prevent creating ambiguous conditional expressions when the guard type overlaps with the other branch's type for the guard variable. This preserves the improved type narrowing from phpstan#5056 (bug phpstan#4173, #12992, #14227) while also fixing the incorrect dependent type narrowing reported in #14411. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#3506
The issue doesn't exists anymore
https://phpstan.org/r/8f0535db-38ce-4ba3-830f-39b6b19e7884