Fix BcMath\Number unary plus/minus/bitwise-not#4980
Open
mpesari wants to merge 1 commit into
Open
Conversation
Contributor
|
I'm not sure it's the right way to do it see Given the fact we have a So maybe the best way to do it the same way is to
But I'd like the confirmation from someone else |
Contributor
|
I did not verify it, but I think we have support for GMP which also supports working with objects on operators. please see whether this can be used as inspiration how BcMath\Number could/should work |
Contributor
|
see e.g. phpstan-src/src/Type/OperatorTypeSpecifyingExtension.php Lines 6 to 10 in e696ed0 |
4 tasks
Contributor
|
You should be able to rework your PR with UnaryOperatorTypeSpecifyingExtension #5284 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#13965
Returning
ObjectType('BcMath\Number')fromtoNumber()fixed+$xand-$xbut caused other tests to fail in these operations (https://github.com/phpstan/phpstan-src/blob/2.1.x/tests/PHPStan/Analyser/nsrt/bcmath-number.php)$a & $b$a | $b$a ^ $b$a << $b$a >> $bThis is fixed by checking for
BcMath\Numberearly and returningErrorTypebefore callingtoNumber()when handling those bitwise operations (getBitwiseAndTypeFromTypes()etc.)I'm not sure if the
*ERROR*->*NEVER*changes in tests fix something or break something?