Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix seemingly same type reports as invalid/incompatible. #5094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VincentLanglet merged 6 commits into from
Mar 1, 2026
Merged

Fix seemingly same type reports as invalid/incompatible. #5094

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
63ad626
Fix false positive invariance check for template types with same iden…
github-actions[bot] Feb 27, 2026
122b06b
Rework
VincentLanglet Feb 28, 2026
3845338
Simplify
VincentLanglet Feb 28, 2026
e4b026a
Add test
VincentLanglet Feb 28, 2026
4692e26
Add non regression test
VincentLanglet Mar 1, 2026
f29c09c
Fix build on 7.4
VincentLanglet Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add non regression test
  • Loading branch information
@VincentLanglet
VincentLanglet committed Mar 1, 2026
commit 4692e261c1091d6899fd23d0af5b2613bd8acc6f
7 changes: 7 additions & 0 deletions tests/PHPStan/Rules/Properties/TypesAssignedToPropertiesRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1025,6 +1025,13 @@ public function testBug12250(): void
$this->analyse([__DIR__ . '/data/bug-12250.php'], []);
}

public function testBug12688(): void
{
$this->checkExplicitMixed = true;
$this->checkImplicitMixed = true;
$this->analyse([__DIR__ . '/data/bug-12688.php'], []);
}

public function testBug4525(): void
{
$this->analyse([__DIR__ . '/data/bug-4525.php'], []);
Expand Down
54 changes: 54 additions & 0 deletions tests/PHPStan/Rules/Properties/data/bug-12688.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
<?php // lint >= 8.1

namespace Bug12688;

/**
* @template T = mixed
*/
interface I {}

/**
* @implements I<mixed>
*/
enum E implements I
{
case E;
}

/**
* @template T
*/
final class TemplateWithoutDefaultWorks
{
/**
* @var I<T>
*/
public readonly I $i;

/**
* @param I<T> $i
*/
public function __construct(I $i = E::E)
{
$this->i = $i;
}
}

/**
* @template T = mixed
*/
final class TemplateWithDefaultDoesNotWork
{
/**
* @var I<T>
*/
public readonly I $i;

/**
* @param I<T> $i
*/
public function __construct(I $i = E::E)
{
$this->i = $i;
}
}
Loading