Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implement GMP operator type specifying extension #5223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VincentLanglet merged 8 commits into from
Apr 7, 2026
Merged

Implement GMP operator type specifying extension #5223

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7da985c
Add test coverage for GMP operator overloads and gmp_* functions
Firehed Mar 15, 2026
eb85b95
Implement GMP operator type specifying extension
Firehed Mar 15, 2026
eaebe39
Add GMP unary operator type specifying extension
Firehed Mar 24, 2026
73b16d4
Refactor GmpOperatorTypeSpecifyingExtension to match BcMath pattern
Firehed Mar 25, 2026
83dbf7e
Fix test compatibility issues
Firehed Mar 25, 2026
f0245d1
Add mutation testing coverage for GmpOperatorTypeSpecifyingExtension
Firehed Mar 25, 2026
7b42b42
Add nsrt tests for mutation testing coverage
Firehed Mar 26, 2026
6cd7a3c
Add string type test to catch isNumericString mutation
Firehed Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add nsrt tests for mutation testing coverage 
- Add GMP + string test to catch TrinaryLogicMutator on isNumericString
- Add unary operator tests on object type to catch mutations in GmpUnaryOperatorTypeSpecifyingExtension

Co-Authored-By: Claude Opus 4.5 <[email protected]>
  • Loading branch information
@Firehed @claude
Firehed and claude committed Mar 26, 2026
commit 7b42b42af65e8cfea3140e733f28f0fecd452395
31 changes: 31 additions & 0 deletions tests/PHPStan/Analyser/nsrt/gmp-operators.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,15 @@ function gmpWithNumericString(\GMP $a, string $s): void
// GMP functions accept numeric strings
assertType('GMP', gmp_add($a, '123'));
assertType('GMP', gmp_mul($a, '456'));

// General string (not numeric-string) has isNumericString()=Maybe
// This catches TrinaryLogicMutator on line 53: isNumericString()->yes() → !isNumericString()->no()
// Without mutation: Maybe.yes()=false → ErrorType
// With mutation: !Maybe.no()=true → GMP (incorrect!)
/** @phpstan-ignore binaryOp.invalid */
assertType('*ERROR*', $a + $s);
/** @phpstan-ignore binaryOp.invalid */
assertType('*ERROR*', $s + $a);
}

/**
Expand All @@ -204,3 +213,25 @@ function nonGmpObjectsDoNotGetGmpTreatment($obj, int $i): void
/** @phpstan-ignore binaryOp.invalid */
assertType('*ERROR*', $i + $obj);
}

/**
* Tests for unary operators on non-GMP objects.
* This catches IsSuperTypeOfCalleeAndArgumentMutator and TrinaryLogicMutator
* on GmpUnaryOperatorTypeSpecifyingExtension line 27.
*
* When mutation swaps $gmpType->isSuperTypeOf($operand) to $operand->isSuperTypeOf($gmpType),
* `object` would incorrectly activate the extension and return GMP.
*
* @param object $obj
*/
function unaryOperatorsOnObjectShouldError($obj): void
{
// Without mutation: extension doesn't activate (GMP not supertype of object)
// With mutation: extension activates (object IS supertype of GMP), returns GMP!
/** @phpstan-ignore unaryOp.invalid */
assertType('*ERROR*', -$obj);
/** @phpstan-ignore unaryOp.invalid */
assertType('*ERROR*', +$obj);
/** @phpstan-ignore unaryOp.invalid */
assertType('*ERROR*', ~$obj);
}
Loading