Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix phpstan/phpstan#11430: Two unbounded generics in conditional return are assumed to be always the same #5336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VincentLanglet merged 3 commits into from
Apr 6, 2026
Merged

Fix phpstan/phpstan#11430: Two unbounded generics in conditional return are assumed to be always the same #5336

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e9f82d
Fix phpstan/phpstan#11430: Two unbounded generics in conditional retu…
github-actions[bot] Mar 29, 2026
ceef2e7
Add additional regression tests for phpstan/phpstan#11430
phpstan-bot Apr 6, 2026
f81b374
Deduplicate bug-11430 test data files for Methods and nsrt
phpstan-bot Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Deduplicate bug-11430 test data files for Methods and nsrt 
Use a single test data file in nsrt/ for both the ReturnTypeRule test
and the NodeScopeResolver assertType test, instead of maintaining two
nearly identical copies.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
  • Loading branch information
@phpstan-bot @claude
phpstan-bot and claude committed Apr 6, 2026
commit f81b3741829f548541b9f1dc626c39f9d4cb4730
4 changes: 2 additions & 2 deletions tests/PHPStan/Analyser/nsrt/bug-11430.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php declare(strict_types = 1);

namespace Bug11430Nsrt;
namespace Bug11430Methods;

use function PHPStan\Testing\assertType;

Expand Down Expand Up @@ -95,4 +95,4 @@ class Test
/** @var ?string $foo */
$foo = null;
$test->name = Option::fromValue($foo);
assertType('Bug11430Nsrt\Option<string>', $test->name);
assertType('Bug11430Methods\Option<string>', $test->name);
2 changes: 1 addition & 1 deletion tests/PHPStan/Rules/Methods/ReturnTypeRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1328,7 +1328,7 @@ public function testBug10924(): void

public function testBug11430(): void
{
$this->analyse([__DIR__ . '/data/bug-11430.php'], []);
$this->analyse([__DIR__ . '/../../Analyser/nsrt/bug-11430.php'], []);
}

}
83 changes: 0 additions & 83 deletions tests/PHPStan/Rules/Methods/data/bug-11430.php
View file
Open in desktop

This file was deleted.

Loading