Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix phpstan/phpstan#14407: !in_array with enum values incorrectly narrows to *NEVER* #5365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VincentLanglet merged 15 commits into from
Apr 1, 2026
Merged

Fix phpstan/phpstan#14407: !in_array with enum values incorrectly narrows to *NEVER* #5365

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
3e9f5ca
Fix phpstan/phpstan#14407: !in_array with enum values incorrectly nar…
phpstan-bot Mar 31, 2026
2692dab
Refactor: use single TypeCombinator::intersect call for performance
phpstan-bot Mar 31, 2026
36073fb
Handle optional keys in constant arrays for !in_array narrowing
phpstan-bot Mar 31, 2026
b36ddd3
Refactor: defer narrowing computation to avoid unnecessary work in !i…
phpstan-bot Mar 31, 2026
7ceb9fd
Refactor: extract computeGuaranteedValueType private method
phpstan-bot Mar 31, 2026
7697ba5
Refactor: extract computeNeedleNarrowingType to unify true/false cont…
phpstan-bot Mar 31, 2026
97bb9cf
Refactor: inline computeGuaranteedValueType into computeNeedleNarrowi…
phpstan-bot Mar 31, 2026
fdf627c
Return null instead of fallback to $arrayValueType when $innerValueTy…
phpstan-bot Mar 31, 2026
95757bf
Refactor: use Type::getArrays() instead of manual union decomposition
phpstan-bot Mar 31, 2026
c51adc8
Skip narrowing for non-constant arrays with multiple possible value t…
phpstan-bot Apr 1, 2026
83bcddf
Rework
VincentLanglet Apr 1, 2026
82aa655
Add instanceof ConstantArrayType to phpstan baseline
phpstan-bot Apr 1, 2026
4fc7fd6
Add non-regression tests for phpstan/phpstan#13421 and phpstan/phpsta…
phpstan-bot Apr 1, 2026
3664373
Remove comment
VincentLanglet Apr 1, 2026
2b059ba
Add non-regression rule tests for strict comparison false positives
phpstan-bot Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor: use single TypeCombinator::intersect call for performance 
Instead of incrementally intersecting types in a loop, collect all inner
value types and pass them to a single TypeCombinator::intersect() call.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
  • Loading branch information
@phpstan-bot @claude @staabm
2 people authored and staabm committed Apr 1, 2026
commit 2692dabd86c4e02727f733ee2ed0b2b47c38cbe4
13 changes: 4 additions & 9 deletions src/Type/Php/InArrayFunctionTypeSpecifyingExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,17 +121,12 @@ public function specifyTypes(FunctionReflection $functionReflection, FuncCall $n
// array{A}|array{B}, getIterableValueType() returns A|B but neither
// value is guaranteed to be in every variant.
$innerTypes = $arrayType instanceof UnionType ? $arrayType->getTypes() : [$arrayType];
$guaranteedValueType = null;
$innerValueTypes = [];
foreach ($innerTypes as $innerType) {
$innerValueType = $innerType->getIterableValueType();
if ($guaranteedValueType === null) {
$guaranteedValueType = $innerValueType;
} else {
$guaranteedValueType = TypeCombinator::intersect($guaranteedValueType, $innerValueType);
}
$innerValueTypes[] = $innerType->getIterableValueType();
}
if ($guaranteedValueType !== null) {
$narrowingValueType = $guaranteedValueType;
if (count($innerValueTypes) > 0) {
$narrowingValueType = TypeCombinator::intersect(...$innerValueTypes);
}
}
if (
Expand Down