Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix phpstan/phpstan#14073: Performance - list the most-often-analysed trait files in -vvv (DiagnoseExtension) #5395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 13 commits into from
Apr 8, 2026
Merged

Fix phpstan/phpstan#14073: Performance - list the most-often-analysed trait files in -vvv (DiagnoseExtension) #5395

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
19b3ca3
List most-often-analysed trait files in -vvv diagnose output
staabm Apr 4, 2026
ede5820
simplify
staabm Apr 4, 2026
ecbb2d7
Update TraitAnalysisDiagnoseExtension.php
staabm Apr 4, 2026
e5d11e7
Update ParallelAnalyser.php
staabm Apr 4, 2026
f3b2343
better names
staabm Apr 4, 2026
efb9618
move files into Analyser namespace
staabm Apr 4, 2026
7485c0a
register with attributes
staabm Apr 4, 2026
a7e01aa
Merge ProcessedFilesDiagnoseExtension into PHPStanDiagnoseExtension
phpstan-bot Apr 5, 2026
22c8198
fix
staabm Apr 5, 2026
91794e0
Update AnalyserRunner.php
staabm Apr 5, 2026
880c799
Remove mutable ProcessedFilesCollector, carry processedFiles through …
phpstan-bot Apr 8, 2026
ab11d4a
Store processedFiles in AnalysisResult, make analyse() return Analysi…
phpstan-bot Apr 8, 2026
f2db6d1
Make AnalyserResult::processedFiles non-optional, remove unused callb…
phpstan-bot Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@staabm
staabm committed Apr 8, 2026
commit 22c81981a91b8c1661ef0d3f72a2e96639a066ba
4 changes: 2 additions & 2 deletions src/Command/AnalyseApplication.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ private function runAnalyser(

if (!$debug) {
$preFileCallback = null;
$postFileCallback = function (int $step, array $processedFiles = []) use ($errorOutput): void {
$postFileCallback = function (int $step, array $processedFiles) use ($errorOutput): void {
$errorOutput->getStyle()->progressAdvance($step);
$this->processedFilesCollector->addProcessedFiles(array_values($processedFiles));
};
Expand All @@ -263,7 +263,7 @@ private function runAnalyser(
$postFileCallback = null;
if ($stdOutput->isDebug()) {
$previousMemory = memory_get_peak_usage(true);
$postFileCallback = function (int $step, array $processedFiles = []) use ($stdOutput, &$previousMemory, &$startTime, &$linesOfCode): void {
$postFileCallback = function (int $step, array $processedFiles) use ($stdOutput, &$previousMemory, &$startTime, &$linesOfCode): void {
if ($startTime === null) {
throw new ShouldNotHappenException();
}
Expand Down
22 changes: 12 additions & 10 deletions src/Diagnose/PHPStanDiagnoseExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,17 +209,19 @@ public function print(Output $output): void
$output->writeLineFormatted('');

$topFiles = $this->processedFilesCollector->getTopMostAnalysedFiles(5);
if (count($topFiles) > 0) {
$output->writeLineFormatted('<info>Most often analysed files:</info>');
foreach ($topFiles as $file => $count) {
$output->writeLineFormatted(sprintf(
' %s: %d times',
$this->simpleRelativePathHelper->getRelativePath($file),
$count,
));
}
$output->writeLineFormatted('');
if (count($topFiles) <= 0) {
return;
}

$output->writeLineFormatted('<info>Most often analysed files:</info>');
foreach ($topFiles as $file => $count) {
$output->writeLineFormatted(sprintf(
' %s: %d times',
$this->simpleRelativePathHelper->getRelativePath($file),
$count,
));
}
$output->writeLineFormatted('');
}

}