Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix phpstan/phpstan#11978: Ordering of Intersections matters for method calls, first matching wins #5408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VincentLanglet merged 5 commits into from
Apr 7, 2026
Merged

Fix phpstan/phpstan#11978: Ordering of Intersections matters for method calls, first matching wins #5408

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
98af204
Fix phpstan/phpstan#11978: Intersection type method calls should not …
VincentLanglet Apr 6, 2026
dee1a72
Extract getMethodWithMostParameters() into cached private method
phpstan-bot Apr 6, 2026
6e3a12f
Add PHPDoc to getMethodWithMostParameters()
phpstan-bot Apr 6, 2026
4c6e74a
Wording
VincentLanglet Apr 6, 2026
61b8eb8
Add more test cases for bug-11978: too many args and zero args
phpstan-bot Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Wording
  • Loading branch information
@VincentLanglet
VincentLanglet committed Apr 7, 2026
commit 4c6e74ac7da2682bb9a8cf7b7318febf89f77580
6 changes: 5 additions & 1 deletion src/Reflection/Type/IntersectionTypeMethodReflection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,11 @@ public function getResolvedPhpDoc(): ?ResolvedPhpDocBlock
return $this->getMethodWithMostParameters()->getResolvedPhpDoc();
}

/** Selects the method whose variant has the widest parameter list, so intersection ordering does not affect call validation. */
/**
* Since every intersected method should be compatible,
* selects the method whose variant has the widest parameter list,
* so intersection ordering does not affect call validation.
*/
private function getMethodWithMostParameters(): ExtendedMethodReflection
{
if ($this->methodWithMostParameters !== null) {
Expand Down