Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Upgrade Dead Code Detector to 1.0.0 #5430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
staabm merged 3 commits into from
Apr 8, 2026
Merged

Upgrade Dead Code Detector to 1.0.0 #5430

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
575c4fa
Upgrade Dead Code Detector to 1.0.0
janedbal Apr 8, 2026
479b591
Fix composer.lock to match rebased composer.json
janedbal Apr 8, 2026
fa03931
Make DCD conditional on PHP 8.1+ to fix old PHP CI
janedbal Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Upgrade Dead Code Detector to 1.0.0 
Co-Authored-By: Claude Code
  • Loading branch information
@janedbal
janedbal committed Apr 8, 2026
commit 575c4faf33b3019bee25bd4dd4efc3e5dfec7780
7 changes: 7 additions & 0 deletions build/phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,11 @@ parameters:
paths:
- ../tests/PHPStan/Fixture
reportUnmatched: false # constants on enums, not reported on PHP8-
-
identifier: shipmonk.deadEnumCase
paths:
- ../tests/PHPStan/Fixture
reportUnmatched: false # enum cases, not reported on PHP8-
-
message: '''
#^Access to constant on deprecated class DeprecatedAnnotations\\DeprecatedFoo\:
Expand Down Expand Up @@ -120,6 +125,8 @@ parameters:
identifier: shipmonk.deadMethod
path: ../src/Internal/CombinationsHelper.php
reportUnmatched: false
-
rawMessage: 'Property PHPStan\Command\CommandHelper::$reservedMemory is never read' # intentional
reportStaticMethodSignatures: true
tmpDir: %rootDir%/tmp
stubFiles:
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
"phpstan/phpstan-strict-rules": "^2.0",
"phpunit/phpunit": "^11.5.23",
"shipmonk/composer-dependency-analyser": "^1.5",
"shipmonk/dead-code-detector": "^0.14.0",
"shipmonk/dead-code-detector": "^1.0.0",
"shipmonk/name-collision-detector": "^2.0"
},
"config": {
Expand Down
73 changes: 40 additions & 33 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/Internal/DirectoryCreatorException.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
final class DirectoryCreatorException extends Exception
{

public function __construct(public readonly string $directory)
public function __construct(string $directory)
{
$error = error_get_last();

Expand Down
Loading