Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bisect: advertise gzip,deflate encoding when supported #5434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 9 commits into from
Apr 13, 2026
Merged

bisect: advertise gzip,deflate encoding when supported #5434

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
42ecacf
bisect: advertise gzip,deflate encoding when supported
staabm Apr 9, 2026
1217816
Update BisectCommand.php
staabm Apr 9, 2026
c9e08aa
cs
staabm Apr 9, 2026
54a0b90
HttpClientFactory
staabm Apr 9, 2026
0b9d21d
Update FixerApplication.php
staabm Apr 9, 2026
7907e12
fix
staabm Apr 9, 2026
4813a6a
Update FixerApplication.php
staabm Apr 9, 2026
f60d353
made HttpClientFactory a service
staabm Apr 10, 2026
dac22f8
centralize timeout
staabm Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@staabm
staabm committed Apr 11, 2026
commit 7907e1232f15dfc4323425ba4054c55d6dc959af
1 change: 0 additions & 1 deletion src/Command/BisectCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int

try {
$commits = $this->getCommitsBetween($client, $good, $bad);
exit;
} catch (GuzzleException $e) {
$io->error(sprintf('Failed to fetch commits from GitHub: %s', $e->getMessage()));
return 1;
Expand Down
2 changes: 2 additions & 0 deletions src/Internal/HttpClientFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ final class HttpClientFactory
{

/**
* @param array<mixed> $config
*
* @see \GuzzleHttp\RequestOptions
*/
public static function createClient(array $config): Client
Copy link
Copy Markdown
Member

@ondrejmirtes ondrejmirtes Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be a service, not a static function. So we can pass options from config parameters

Expand Down