Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Don't remember types after impure assignments #5514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
staabm wants to merge 15 commits into from
Closed

Don't remember types after impure assignments #5514

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a740556
Don't remember types after impure assignments
staabm Apr 23, 2026
0c53e50
Update AssignHandler.php
staabm Apr 23, 2026
a07105f
Update bug-3190.php
staabm Apr 23, 2026
ab56e42
discard impure call knowledge
staabm Apr 23, 2026
1ca65f5
Update AssignHandler.php
staabm Apr 23, 2026
894390f
fix
staabm Apr 23, 2026
6e84a69
Update AssignHandler.php
staabm Apr 23, 2026
c55f7ba
Update AssignHandler.php
staabm Apr 24, 2026
676bcd8
tests
staabm Apr 24, 2026
262c28a
Update functionMetadata_original.php
staabm Apr 24, 2026
ba701ce
more tests
staabm Apr 24, 2026
828b15a
Update AssignHandler.php
staabm Apr 24, 2026
ccaaae9
test rememberPossiblyImpureFunctionValues
staabm Apr 24, 2026
28b1b9b
Update AssignHandler.php
staabm Apr 24, 2026
b6ba210
fix build
staabm Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
more tests
  • Loading branch information
@staabm
staabm committed Apr 24, 2026
commit ba701cea561b7949581576a342307ce53b940158
37 changes: 27 additions & 10 deletions tests/PHPStan/Analyser/nsrt/bug-9455.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public function getId(): int {
/**
* @phpstan-pure
*/
public function getA(): ?A {
public function getPure(): ?A {
return $this->a;
}
}
Expand All @@ -36,10 +36,10 @@ public function testFails(): void
$a = new A(1);
$b = new B(1, $a);

$hasA = $b->getA() !== null;
$hasA = $b->getPure() !== null;

if($hasA) {
assertType('Bug9455\A', $b->getA());
assertType('Bug9455\A', $b->getPure());
}
}

Expand All @@ -48,8 +48,8 @@ public function testSucceeds(): void
$a = new A(1);
$b = new B(1, $a);

if($b->getA() !== null) {
assertType('Bug9455\A', $b->getA());
if($b->getPure() !== null) {
assertType('Bug9455\A', $b->getPure());
}
}
}
Expand All @@ -58,7 +58,7 @@ class C {
/**
* @phpstan-impure
*/
public function getA(): ?A {
public function getImpure(): ?A {
return rand(0, 1) ? new A(1) : null;
}
}
Expand All @@ -69,19 +69,36 @@ public function testImpureMethodNotNarrowed(): void
{
$c = new C();

$hasA = $c->getA() !== null;
$hasA = $c->getImpure() !== null;

if($hasA) {
assertType('Bug9455\A|null', $c->getA());
assertType('Bug9455\A|null', $c->getImpure());
}
}

public function testImpureMethodInline(): void
{
$c = new C();

if($c->getA() !== null) {
assertType('Bug9455\A|null', $c->getA());
if($c->getImpure() !== null) {
assertType('Bug9455\A|null', $c->getImpure());
}
}
}

class D {
public function getUnknownPurity(): ?A {
return rand(0, 1) ? new A(1) : null;
}
}

function doUnknownPurity(): void
{
$d = new D();

$hasA = $d->getUnknownPurity() !== null;

if($hasA) {
assertType('Bug9455\A|null', $d->getUnknownPurity());
}
}