Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Track more expressions #5596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VincentLanglet merged 6 commits into from
May 5, 2026
Merged

Track more expressions #5596

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f116827
Try
VincentLanglet May 4, 2026
0ba2ac3
Add tests
VincentLanglet May 4, 2026
e956c08
Add tests
VincentLanglet May 4, 2026
6b65e44
Remove regression test
VincentLanglet May 4, 2026
5803d25
Use right-side scope only for non-Variable expressions in conditional…
phpstan-bot May 4, 2026
f9280ed
Add test
VincentLanglet May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add test
  • Loading branch information
@VincentLanglet
VincentLanglet committed May 4, 2026
commit f9280edc375dc811363cce3e1535bba707852dfa
42 changes: 42 additions & 0 deletions tests/PHPStan/Analyser/nsrt/pr-5596.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
<?php

namespace Pr5596;

use PhpParser\Node\Expr\CallLike;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\New_;
use PhpParser\Node\Expr\StaticCall;
use PhpParser\Node\Identifier;
use PhpParser\Node\Name;
use PHPStan\Analyser\Scope;

use function PHPStan\Testing\assertType;

class Test
{
private function whitelistAllowedCallables(
CallLike $node,
Scope $scope
): void
{
if ($node instanceof MethodCall && $node->name instanceof Identifier) {
assertType('PhpParser\Node\Expr\MethodCall', $node);
assertType('PhpParser\Node\Identifier', $node->name);
assertType('PhpParser\Node\Expr', $node->var);
} elseif ($node instanceof StaticCall && $node->name instanceof Identifier && $node->class instanceof Name) {
assertType('PhpParser\Node\Expr\StaticCall', $node);
assertType('PhpParser\Node\Identifier', $node->name);
assertType('PhpParser\Node\Name', $node->class);
} elseif ($node instanceof New_ && $node->class instanceof Name) {
assertType('PhpParser\Node\Expr\New_', $node);
assertType('PhpParser\Node\Name', $node->class);
} elseif ($node instanceof FuncCall && $node->name instanceof Name) {
assertType('PhpParser\Node\Expr\FuncCall', $node);
assertType('PhpParser\Node\Name', $node->name);
} elseif ($node instanceof FuncCall) {
assertType('PhpParser\Node\Expr\FuncCall', $node);
assertType('PhpParser\Node\Expr', $node->name);
}
}
}
Loading