Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added regression test #5652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
staabm merged 6 commits into from
May 13, 2026
Merged

Added regression test #5652

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0335c70
Added regression test
staabm May 13, 2026
05a5262
Update CatchWithUnthrownExceptionRuleTest.php
staabm May 13, 2026
133e7c8
cs
staabm May 13, 2026
a971015
Update bug-14569.php
staabm May 13, 2026
d13c9c3
Update CatchWithUnthrownExceptionRuleTest.php
staabm May 13, 2026
61ae2ea
Update bug-14569.php
staabm May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Added regression test
  • Loading branch information
@staabm
staabm committed May 13, 2026
commit 0335c70f991f02d585900bd6245f42d42ba9891c
7 changes: 7 additions & 0 deletions tests/PHPStan/Rules/Exceptions/CatchWithUnthrownExceptionRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,4 +792,11 @@ public function testBug5952(): void
]);
}

#[RequiresPhp('>= 8.3.0')]
public function testBug14569(): void
{
$this->analyse([__DIR__ . '/data/bug-14569.php'], []);
}


}
14 changes: 14 additions & 0 deletions tests/PHPStan/Rules/Exceptions/data/bug-14569.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<?php

namespace Bug14569;

use DateInterval;
use DateMalformedIntervalStringException;
use DateMalformedStringException;

try {
DateInterval::createFromDateString('FAIL');
} catch (DateMalformedIntervalStringException $e) {
var_dump($e::class);
var_dump($e instanceof DateMalformedStringException);
Copy link
Copy Markdown
Contributor

@VincentLanglet VincentLanglet May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line feels weird in the regression test since its always false

Maybe better to not have it to avoid confusing people ?

}