Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Preserve TemplateType in ArrayType and IntersectionType array-mutating methods #5698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
staabm merged 6 commits into from
May 18, 2026
+220 −25
Merged

Preserve TemplateType in ArrayType and IntersectionType array-mutating methods #5698

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
749d403
Preserve `TemplateType` in `ArrayType` and `IntersectionType` array-m…
staabm May 18, 2026
5ca56ea
Extract `intersectTypesPreserveTemplateType()` helper in `Intersectio…
phpstan-bot May 18, 2026
91eff28
Add tests verifying template types are only preserved on lists for ge…
phpstan-bot May 18, 2026
f4baea8
Use `intersectTypesPreserveTemplateType` conditionally in `getValuesA…
phpstan-bot May 18, 2026
212a920
Update IntersectionType.php
staabm May 18, 2026
9d7d527
Revert ArrayFilterFunctionReturnTypeHelper changes and related assert…
phpstan-bot May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update IntersectionType.php
  • Loading branch information
@staabm
staabm committed May 18, 2026
commit 212a920abf8bc2525cf8abc5698172b9fa7ff3ce
2 changes: 1 addition & 1 deletion src/Type/IntersectionType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1153,7 +1153,7 @@
{
$cb = static fn (Type $type): Type => $type->getValuesArray();
if ($this->isList()->yes()) {
return $this->intersectTypesPreserveTemplateType($cb);
return $this;
}
return $this->intersectTypes($cb);
}
Expand Down Expand Up @@ -1201,7 +1201,7 @@
public function shuffleArray(): Type
{
$cb = static fn (Type $type): Type => $type->shuffleArray();
if ($this->isList()->yes()) {

Check warning on line 1204 in src/Type/IntersectionType.php

View workflow job for this annotation

GitHub Actions / Mutation Testing (8.3, ubuntu-latest) 

Escaped Mutant for Mutator "PHPStan\Infection\TrinaryLogicMutator":

@@ @@
 	public function shuffleArray(): Type
 	{
 		$cb = static fn (Type $type): Type => $type->shuffleArray();
-		if ($this->isList()->yes()) {
+		if (!$this->isList()->no()) {
 			return $this->intersectTypesPreserveTemplateType($cb);
 		}
 		return $this->intersectTypes($cb);

Check warning on line 1204 in src/Type/IntersectionType.php

View workflow job for this annotation

GitHub Actions / Mutation Testing (8.4, ubuntu-latest) 

Escaped Mutant for Mutator "PHPStan\Infection\TrinaryLogicMutator":

@@ @@
 	public function shuffleArray(): Type
 	{
 		$cb = static fn (Type $type): Type => $type->shuffleArray();
-		if ($this->isList()->yes()) {
+		if (!$this->isList()->no()) {
 			return $this->intersectTypesPreserveTemplateType($cb);
 		}
 		return $this->intersectTypes($cb);
return $this->intersectTypesPreserveTemplateType($cb);
}
return $this->intersectTypes($cb);
Expand Down
Loading