Optimize JournalRepository #2007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, nice catch |
nabeelio
pushed a commit
that referenced
this pull request
Mar 13, 2025
(cherry picked from commit 45ff0e1)
nabeelio
added a commit
that referenced
this pull request
May 7, 2025
* Version output fixes (#1954) * Set the label to be blank * Fix how the version is parsed when there's no pre-release version specified * Update the latest metadata * Correctly output the build metadata * Update the version file * Version Tweaks * Set the mode and incrementals * Tweaks to version file * fix: fix hcaptcha sitekey tag (#1979) * [7.x] Add log viewer (#1972)a * add opcodesio/log-viewer * set up with custom permission --------- Co-authored-by: Nabeel S. <[email protected]> * Fix pint workflow (#1974) * [7.x] Add `access_admin` gate (#1975) * Add access_admin gate * Add example in seven theme nav * Add missing ',' in email-plain.blade.php (#1987) * Update airport IDs/ICAOs to enforce 8-character format (#1988) * Update airport IDs/ICAOs to 8 chars * Add nullable (L11 support) * Update FlightImporter.php (#1983) * Fix module menu icon * Update FlightImporter.php Closes #1982 Use `0` instead of `null` to follow the `setDays()` function and have a proper match for `firstorNew()` --------- Co-authored-by: Nabeel S. <[email protected]> * Register UpdateSimBriefData Listener (#1999) * Update default activity log retention time (#2000) * Merge commit from fork * Optimize JournalRepository (#2007) * Remove vendor from .htaccess (#1994) * Move policies * update guessPolicyNamesUsing * wip * Run pint * Fixes float -> int overflow problem in certain systems. Fixes float -> int overflow problem in certain systems. * Add Refresh Token System for OAuth Tokens (#1997) * Add OAuthTokens refresh logic * Add tests * Run pint * Update IVAO tokens policy * Update tests --------- Co-authored-by: Nabeel S. <[email protected]> * Aircraft's FIN should be unique (#2015) * Add Pre-Commit Hooks (#1993) * Add pre commit hooks * Fix hooks registration * Fix hooks permissions * Test pre commit hooks * Update pint workflow --------- Co-authored-by: Nabeel S. <[email protected]> * Update PirepFiled.php (#2036) Do not load relationships of the `pirep` model while using it for notifications. * Update Notification (PirepFiled) (#2036) * Update PirepFiled.php Do not load relationships of the `pirep` model while using it for notifications. * Update NotificationEventsHandler.php Add `->withoutRelations()` call to outgoing mails --------- Co-authored-by: Nabeel S. <[email protected]> * Merge branch 'feature/8.0' (#2041) * Run rector * Run rector * update packages * refactor RolePolicy --------- Co-authored-by: Nabeel S. <[email protected]> Co-authored-by: Arthur Hetem <[email protected]> Co-authored-by: B.Fatih KOZ <[email protected]> Co-authored-by: Nabeel S. <[email protected]> Co-authored-by: Taylor Broad <[email protected]> Co-authored-by: Fikret Anıl Haksever <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
findWhereretrieves all entries matching thewherestatement, meaning we were fetching all those entries and then summing them manually, which was not optimized. With this PR, we now sum directly in SQL.This results in a huge improvement for large journals -
FinanceEventHandlerexecution time dropped from over 13 seconds to less than 1 second on my prodChanges in
app/Repositories/JournalRepository.php:findWheretowhereinrecalculateBalancefunction to improve query consistency.Should be applied to both
v7andv8