tests/Unit/AirlineTest.php (1)

9-31: Consider splitting this test or completing the second scenario verification.

This test combines two scenarios: (1) creating an airline and verifying its journal, and (2) creating a second airline with an empty IATA. However, the journal verification is only performed for the first airline. Either:

• Split into two separate tests (it('can add an airline') and it('can add multiple airlines with empty IATA')) for better isolation.
• Or complete the second scenario by also verifying the journal for the second airline.

♻️ Proposed refactor: split into focused tests

 it('can add an airline', function () {
     $attrs = Airline::factory()->make([
         'iata' => '',
     ])->toArray();

     $airline = app(AirlineService::class)->createAirline($attrs);
     expect($airline)->not->toBeNull();

     // Ensure only a single journal is created
     $journals = Journal::where([
         'morphed_type' => Airline::class,
         'morphed_id'   => $airline->id,
     ])->get();

     expect($journals)->toHaveCount(1);
+});

-    // Add another airline, also blank IATA
-    $attrs = Airline::factory()->make([
+it('can add multiple airlines with empty IATA', function () {
+    $attrs = Airline::factory()->make([
+        'iata' => '',
+    ])->toArray();
+    $firstAirline = app(AirlineService::class)->createAirline($attrs);
+    expect($firstAirline)->not->toBeNull();
+
+    $attrs = Airline::factory()->make([
         'iata' => '',
     ])->toArray();
-    $airline = app(AirlineService::class)->createAirline($attrs);
-    expect($airline)->not->toBeNull();
+    $secondAirline = app(AirlineService::class)->createAirline($attrs);
+    expect($secondAirline)->not->toBeNull();
+    expect($secondAirline->id)->not->toBe($firstAirline->id);
 });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Unit/AirlineTest.php` around lines 9 - 31, The test mixes two
scenarios; split them or add assertions for the second airline: create a new
separate test (e.g., it('can add multiple airlines with empty IATA')) or keep
the current test but after creating the second airline call
Journal::where(['morphed_type' => Airline::class, 'morphed_id' =>
$airline->id])->get() and assert expect($journals)->toHaveCount(1); reference
the Airline::factory()->make([...]), AirlineService::createAirline, and Journal
to locate the code to change and ensure each test only verifies the journals for
the airline instance it just created.

tests/Feature/OAuthTest.php (1)

53-56: Prefer factories/custom states + Faker over repeated hard-coded fixtures.

There’s repeated manual setup for users/tokens and hard-coded identity strings. Consolidate with factories/states and Faker to reduce duplication and align test conventions.

Refactor direction

-    $user = User::factory()->create([
-        'name'  => 'OAuth user',
-        'email' => '[email protected]',
-    ]);
+    $user = User::factory()->create([
+        'name'  => fake()->name(),
+        'email' => fake()->safeEmail(),
+    ]);
...
-        UserOAuthToken::create([
-            'user_id'       => $user->id,
-            'provider'      => $driver,
-            'token'         => 'token',
-            'refresh_token' => 'refresh_token',
-        ]);
+        UserOAuthToken::factory()->for($user)->create([
+            'provider'      => $driver,
+            'token'         => 'token',
+            'refresh_token' => 'refresh_token',
+        ]);

Based on learnings: "When creating models for tests, use factories for the models and check for custom states before manually setting up the model" and "Use Faker methods such as $this->faker->word() or fake()->randomDigit(), following existing conventions."

Also applies to: 78-81, 105-108, 115-120, 142-146, 166-169, 207-210, 217-226

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Feature/OAuthTest.php` around lines 53 - 56, Replace the repeated
hard-coded user/token fixtures and identity strings in OAuthTest with factory
states and Faker: create/extend UserFactory and any Token/Identity factories
with custom states (e.g., ->state(['name' => fn() => $this->faker->name(),
'email' => fn() => $this->faker->unique()->safeEmail()])) and then use those in
the test instead of literal values (replace direct
User::factory()->create([...]) and manual token setup with
User::factory()->verified()->create() or
Token::factory()->for($user)->createOne(), and use $this->faker or fake()->...
for random identity strings), ensuring tests reference the factory state names
(e.g., verified) and generated faker values rather than hard-coded strings.

tests/Feature/CronTest.php (1)

67-67: Remove or rewrite the inline comments; two are also inaccurate.

The repeated “Make sure the state is accepted” comment is incorrect in rejected/cancelled tests, and these comments are unnecessary noise here.

As per coding guidelines "**/*.php: Prefer PHPDoc blocks over inline comments; never use comments within the code itself unless the logic is exceptionally complex".

Also applies to: 83-83, 99-99

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Feature/CronTest.php` at line 67, In CronTest.php remove the inline
comment string "Make sure the state is accepted" (and its duplicates in the
other tests) from the test methods that assert rejected/cancelled states and
either delete the comment entirely or replace it with a short PHPDoc above the
test method (e.g., /** Asserts job transitions to rejected/cancelled/accepted
*/) so the inaccurate inline comments are not left in the body; locate
occurrences by searching for that exact comment text inside the test methods and
update the tests accordingly (preserve assertions and test logic in methods like
the cron-related test functions).

tests/Feature/GeoTest.php (2)

4-6: WithoutMiddleware appears unnecessary for service-level tests.

These tests resolve GeoService from the container and call methods directly without making HTTP requests. The WithoutMiddleware trait only affects HTTP test requests, so it has no effect here.

♻️ Suggested cleanup

 <?php

 use App\Models\Navdata;
-use Illuminate\Foundation\Testing\WithoutMiddleware;
-
-uses(WithoutMiddleware::class);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Feature/GeoTest.php` around lines 4 - 6, Remove the unnecessary
WithoutMiddleware import and the uses(WithoutMiddleware::class) call from
GeoTest; since the tests resolve GeoService from the container and call its
methods directly (no HTTP requests), delete the line importing
Illuminate\Foundation\Testing\WithoutMiddleware and the uses(...) invocation so
the test class no longer references the trait (verify no other tests in this
file rely on middleware disabling before pushing).

---

8-32: LGTM! Minor style suggestion.

The test correctly validates the getClosestCoords method with well-documented test coordinates. Consider using ::class syntax for better IDE support and refactoring safety:

-    $geoSvc = app('\App\Services\GeoService');
+    $geoSvc = app(\App\Services\GeoService::class);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Feature/GeoTest.php` around lines 8 - 32, Replace the hard-coded
service string in the test with class-constant syntax to improve
IDE/refactorability: change the app('\App\Services\GeoService') call used to get
$geoSvc in the test to use \App\Services\GeoService::class (or import the class
and call app(GeoService::class)); keep the rest of the test and the
getClosestCoords assertions unchanged.

tests/Feature/SubfleetTest.php (1)

7-37: Split this lifecycle check into focused tests.

This single example covers attach, override, and delete behavior, so the current name is misleading and failures are harder to localize. Separate these into dedicated Pest tests and drop the inline // narration.

As per coding guidelines, "Prefer PHPDoc blocks over inline comments; never use comments within the code itself unless the logic is exceptionally complex."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Feature/SubfleetTest.php` around lines 7 - 37, Split the single Pest
test named test('subfleet fares no override', ...) into three focused tests in
SubfleetTest.php: one that verifies attaching a fare using
FareService::setForSubfleet and reading it with FareService::getForSubfleet
(assert count and original price/capacity), one that verifies overriding a fare
by calling FareService::setForSubfleet with override attributes and asserting
the updated price/capacity via getForSubfleet, and one that verifies deletion
using FareService::delFareFromSubfleet and asserting getForSubfleet returns an
empty collection; remove the inline // comments and narration and give each new
test a descriptive name reflecting the single behavior it verifies.

tests/Feature/AwardsTest.php (1)

16-19: Assertion expects count but compares collection directly.

$classes is likely an array or collection returned by findAllAwardClasses(), but toBeGreaterThanOrEqual(2) performs a numeric comparison. This may work if the collection implements Countable and Pest handles it, but the intent is clearer with an explicit count assertion.

♻️ Clearer assertion

 test('get awards classes', function () {
     $classes = app(AwardService::class)->findAllAwardClasses();
-    expect($classes)->toBeGreaterThanOrEqual(2);
+    expect($classes)->toHaveCountGreaterThanOrEqual(2);
 });

Or if that method isn't available:

-    expect($classes)->toBeGreaterThanOrEqual(2);
+    expect(count($classes))->toBeGreaterThanOrEqual(2);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Feature/AwardsTest.php` around lines 16 - 19, The test "get awards
classes" is comparing the collection directly with toBeGreaterThanOrEqual;
change the assertion to check the actual count of the result from
AwardService::findAllAwardClasses() (use count($classes) or $classes->count()
depending on the return type) and assert that the count is >= 2 so the intent is
explicit and correct.

tests/Pest.php (1)

39-40: Remove commented-out dead code.

Line 40 is a duplicate of the RefreshDatabase usage on line 25. Remove to avoid confusion.

🧹 Remove dead code

     ->in('Unit', 'Feature', 'Arch', '../resources/views');
-// ->use(Illuminate\Foundation\Testing\RefreshDatabase::class)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Pest.php` around lines 39 - 40, Remove the commented-out duplicate of
the RefreshDatabase usage (the line starting with "//
->use(Illuminate\Foundation\Testing\RefreshDatabase::class)") from tests' Pest
bootstrap so only the intended single use(...) call remains; locate the
commented line near the existing ->use(RefreshDatabase::class) invocation and
delete that dead/commented code to avoid confusion.

tests/Helpers/DatabaseHelpers.php (1)

27-30: Add type hint for $value parameter.

Per coding guidelines, use appropriate PHP type hints for method parameters. The $value parameter lacks a type hint.

♻️ Add type hint

-function updateSetting(string $key, $value): void
+function updateSetting(string $key, mixed $value): void
 {
     app(SettingRepository::class)->store($key, $value);
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Helpers/DatabaseHelpers.php` around lines 27 - 30, The updateSetting
function lacks a type hint for its $value parameter; update the signature of
updateSetting to include an appropriate PHP type (e.g., mixed if settings can be
different types or string/int/float/bool if known) and ensure the call to
SettingRepository::store($key, $value) remains compatible; update any related
usages/tests if necessary to satisfy the new type hint and keep the function
signature consistent with SettingRepository::store's parameter type.

tests/Feature/DatabaseTest.php (1)

7-10: Remove unused $dbSvc variable declaration.

The PHPDoc @var DatabaseService $dbSvc appears in all three tests but the variable is never used. This appears to be a copy-paste artifact.

🧹 Remove unused declarations

 test('seeder', function () {
-    /** `@var` DatabaseService $dbSvc */
     $file = file_get_contents(base_path('tests/data/seed.yml'));

Apply similar changes to tests at lines 31-34 and 49-52.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Feature/DatabaseTest.php` around lines 7 - 10, Remove the unused
PHPDoc/variable declaration "@var DatabaseService $dbSvc" from the tests (it’s a
copy‑paste artifact) — delete the line that declares $dbSvc in the 'seeder' test
and the same declaration in the two other tests so no unused $dbSvc remains;
ensure no remaining references to DatabaseService $dbSvc are left in those test
functions.

tests/Feature/AcarsTest.php (2)

593-593: Fix typo in test name.

"instantitaion" should be "instantiation".

✏️ Proposed fix

-test('acars data instantitaion', function () {
+test('acars data instantiation', function () {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Feature/AcarsTest.php` at line 593, Rename the test description string
in the test declaration that currently reads "acars data instantitaion" to the
correct spelling "acars data instantiation" (the test call starting with
test('acars data instantitaion', function () { in AcarsTest.php); update only
the human-readable test name—leave the test body and function unchanged.

---

21-26: Remove redundant conditional assignment.

Lines 23-25 are redundant: if $addtl_fields === [] is true, assigning $addtl_fields = [] does nothing.

🔧 Proposed fix

 function allPointsInRoute(array $route, array $points, array $addtl_fields = []): void
 {
-    if ($addtl_fields === []) {
-        $addtl_fields = [];
-    }
-
     $fields = array_merge(
         [
             'name',

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Feature/AcarsTest.php` around lines 21 - 26, The conditional inside the
allPointsInRoute function that checks if $addtl_fields === [] and then assigns
$addtl_fields = [] is redundant; remove that if-block entirely and rely on the
default parameter declaration (array $addtl_fields = []) so the parameter is
already an empty array when not provided, leaving the rest of allPointsInRoute
unchanged.

tests/Arch/ProvidersTest.php (1)

3-4: Minor: Add blank line after declare statement.

PSR-12 recommends a blank line after declare(strict_types=1) before the use statements.

✏️ Proposed fix

 declare(strict_types=1);
+
 use Illuminate\Support\ServiceProvider;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Arch/ProvidersTest.php` around lines 3 - 4, Add a blank line after the
file-level declare statement so PSR-12 spacing is respected: insert an empty
line between the existing declare(strict_types=1); statement and the following
use Illuminate\Support\ServiceProvider; line in Tests/Arch/ProvidersTest.php
(i.e., separate the declare(...) from the use statements).

tests/Feature/VersionTest.php (1)

26-36: Inconsistent setting helper usage.

Line 27 uses setting() while lines 39, 51, and 69 use updateSetting(). Consider using a consistent helper for test clarity.

✏️ Proposed fix

 test('get latest version', function () {
-    setting('general.check_prerelease_version', false);
+    updateSetting('general.check_prerelease_version', false);

     mockGuzzleResponse('releases.json', 'application/json; charset=utf-8');

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Feature/VersionTest.php` around lines 26 - 36, In the "get latest
version" test, replace the inconsistent helper call
setting('general.check_prerelease_version', false) with the same helper used
elsewhere (updateSetting) so the test consistently uses
updateSetting('general.check_prerelease_version', false); locate the call in the
test function (test('get latest version', ...)) and update it accordingly so
VersionService::getLatestVersion() and the subsequent assertion against
KvpRepository::get('latest_version_tag') run under the same setting helper
convention.

tests/Arch/ModelsTest.php (1)

44-68: Malformed PHPDoc annotations in commented code.

Lines 48 and 58 have malformed PHPDoc comments (missing * before @var). If you plan to re-enable these tests in the future, fix the annotations.

✏️ Proposed fix (for when uncommenting)

-         `@var` \Illuminate\Database\Eloquent\Factories\HasFactory $model
+        /** `@var` \Illuminate\Database\Eloquent\Factories\HasFactory $model */

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Arch/ModelsTest.php` around lines 44 - 68, Fix the malformed PHPDoc
annotations inside the commented tests for arch('ensure factories') and
arch('ensure datetime casts') by replacing the lines that read " `@var`
\Illuminate\Database\Eloquent\Factories\HasFactory $model" with a valid inline
PHPDoc such as "/** `@var` \\Illuminate\\Database\\Eloquent\\Factories\\HasFactory
$model */" (or a single-line comment "/* `@var`
\\Illuminate\\Database\\Eloquent\\Factories\\HasFactory $model */") so the
annotation is syntactically correct and will parse if these tests are
uncommented; update the annotation occurrences adjacent to getModels(), $model
and $instance usages accordingly.

tests/Feature/ApiTest.php (3)

319-320: Clarify or remove commented-out assertions.

Multiple commented-out assertions exist throughout this test (lines 319-320, 327-328, 338-339). If these are temporarily disabled due to a known issue, add a TODO comment explaining why. Otherwise, remove them to keep the test clean.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Feature/ApiTest.php` around lines 319 - 320, The commented-out
assertions ($this->assertEquals calls comparing $body['mtow'] to
$aircraft->mtow->local(0) and $body['zfw'] to $aircraft->zfw->local(0), and the
similar pairs elsewhere) should either be removed or annotated with a TODO
explaining why they're disabled; update tests/Feature/ApiTest.php by either
deleting those commented assertions or replacing each comment with a one-line
TODO that states the known issue or ticket (e.g., "TODO: disabled due to
<issue-id> - re-enable when <condition>") so future readers know whether they
are intentionally skipped or can be safely removed.

---

352-360: Consider using assertStringContainsString for clarity.

Using strpos() !== -1 is less readable than Laravel's built-in assertion methods.

Proposed fix

-    $this->assertNotSame(-1, strpos($user['avatar'], 'http'));
+    $this->assertStringContainsString('http', $user['avatar']);

     // Should go to gravatar
     $user = User::factory()->create();

     $res = $this->get('/api/user')->assertStatus(200);
     $user = $res->json('data');
     expect($user)->not->toBeNull();
-    $this->assertNotSame(-1, strpos($user['avatar'], 'gravatar'));
+    $this->assertStringContainsString('gravatar', $user['avatar']);

Or using Pest's expect() style for consistency with the rest of the file:

expect($user['avatar'])->toContain('http');
// ...
expect($user['avatar'])->toContain('gravatar');

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Feature/ApiTest.php` around lines 352 - 360, Replace the manual strpos
comparisons used in the assertions with clearer, built-in string assertions:
change calls like $this->assertNotSame(-1, strpos($user['avatar'], 'http')) and
$this->assertNotSame(-1, strpos($user['avatar'], 'gravatar')) to use PHPUnit's
assertStringContainsString('http', $user['avatar']) /
assertStringContainsString('gravatar', $user['avatar']) or, to match the file's
Pest style, use expect($user['avatar'])->toContain('http') and
expect($user['avatar'])->toContain('gravatar'); update the assertions around the
get('/api/user')->assertStatus(200) block and the User::factory()->create()
section accordingly so the tests remain equivalent but more readable.

---

3-3: Remove commented-out import.

Dead code should be cleaned up. This commented import is unused.

Proposed fix

 <?php
 
-// use Swagger\Serializer;
 use App\Models\Aircraft;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Feature/ApiTest.php` at line 3, Remove the dead commented import in
tests/Feature/ApiTest.php by deleting the commented line "// use
Swagger\Serializer;"; ensure no other commented-out unused imports remain in the
ApiTest class or file so the file only contains active, necessary use
statements.

tests/Feature/MetarTest.php (1)

121-127: Variable shadowing reduces readability.

The variable $metar is used for both the input string and the parsed result in multiple tests (lines 123, 130, 139, 148, 156, 164). While not incorrect, this shadowing can be confusing during debugging.

Consider using distinct variable names like $metarString and $parsed for clarity.

Example fix for one occurrence

 test('metar trends3', function () {
-    $metar = 'EHAM 041455Z 13012KT 9999 FEW034CB BKN040 05/01 Q1007 TEMPO 14017G28K 4000 SHRA =';
-    $metar = Metar::parse($metar);
+    $metarString = 'EHAM 041455Z 13012KT 9999 FEW034CB BKN040 05/01 Q1007 TEMPO 14017G28K 4000 SHRA =';
+    $parsed = Metar::parse($metarString);
 
-    expect($metar['category'])->toEqual('VFR');
+    expect($parsed['category'])->toEqual('VFR');
 });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Feature/MetarTest.php` around lines 121 - 127, Replace the shadowed
$metar variable in the test blocks by giving the raw METAR string and the parsed
result distinct names (e.g., rename the input $metar string to $metarString and
the parsed output from Metar::parse(...) to $parsed or $metarParsed) in the
test('metar trends3', function () { ... }) and the other affected tests (the
functions that call Metar::parse); update all subsequent assertions and
references to use the new parsed variable name (e.g.,
expect($metarParsed['category'])->toEqual('VFR')) so the input and parsed values
are not shadowing each other.

tests/Feature/RegistrationTest.php (1)

87-105: Consider faking notifications for invite registration test.

This test also POSTs to /register, which may trigger notification/email sending. For consistency and to prevent potential pipeline failures, consider adding Notification::fake() here as well.

Proposed fix

 test('access with valid invite', function () {
+    Notification::fake();
+
     updateSetting('general.disable_registrations', false);
     updateSetting('general.invite_only_registrations', true);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Feature/RegistrationTest.php` around lines 87 - 105, Add a
Notification::fake() call in the "access with valid invite" test before the POST
to /register to prevent real emails/notifications from being sent; update the
test closure that creates the Invite (the test named "access with valid invite")
to call Notification::fake() (or
\Illuminate\Support\Facades\Notification::fake() if not imported) just before
$this->post('/register', $userData) so the Invite::create and
$this->post('/register', $userData) flow uses the fake notifications.

tests/Helpers/DatabaseHelpers.php (3)

23-25: Type-hint $value explicitly in updateSetting.

$value is currently untyped. Use mixed so the signature stays explicit and consistent with the project rules.

Suggested change

-function updateSetting(string $key, $value): void
+function updateSetting(string $key, mixed $value): void
 {
     app(SettingRepository::class)->store($key, $value);
 }

As per coding guidelines: "Use appropriate PHP type hints for method parameters".

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Helpers/DatabaseHelpers.php` around lines 23 - 25, The updateSetting
helper currently leaves $value untyped; update the function signature for
updateSetting to explicitly type-hint the second parameter as mixed (e.g.,
change to function updateSetting(string $key, mixed $value): void) and ensure
any calls to updateSetting still pass compatible values; this aligns with the
project's typing rules and matches the SettingRepository::store usage.

---

54-54: Remove inline comment in helper body.

The inline comment is unnecessary here and can be dropped.

As per coding guidelines: "Prefer PHPDoc blocks over inline comments; never use comments within the code itself unless the logic is exceptionally complex".

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Helpers/DatabaseHelpers.php` at line 54, Remove the inline comment "//
Return a Pirep model" from the helper body in tests/Helpers/DatabaseHelpers.php;
locate the helper function that returns the Pirep model (the method containing
that inline comment) and delete that comment, keeping the function body
unchanged, or if documentation is needed, move the text into the function's
PHPDoc block above the method instead.

---

45-59: createPirep() name implies persistence, but it returns an unsaved model.

This helper uses make(), so callers can easily forget to persist the model. Consider renaming to makePirep() or persisting before returning to avoid test setup mistakes.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Helpers/DatabaseHelpers.php` around lines 45 - 59, The helper
createPirep() currently calls Pirep::factory()->make() and returns an unsaved
model which contradicts its name; either rename the function to makePirep() to
reflect that it returns an unsaved instance, or persist the Pirep before
returning by replacing Pirep::factory()->make(...) with
Pirep::factory()->create(...) (ensure related callers expect a saved model when
changing behavior); update references to createPirep() accordingly if you rename
it so tests remain correct.

tests/Feature/SimBriefTest.php (3)

64-71: Add concrete parameter types to downloadOfp().

$user, $flight, $aircraft, and $fares should be type-hinted for consistency and safer test helpers.

Suggested change

-function downloadOfp($user, $flight, $aircraft, $fares): ?SimBrief
+function downloadOfp(User $user, Flight $flight, Aircraft $aircraft, array $fares): ?SimBrief
 {

As per coding guidelines: "Use appropriate PHP type hints for method parameters".

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Feature/SimBriefTest.php` around lines 64 - 71, Update the test helper
function signature for downloadOfp to add concrete PHP type hints for
parameters: type-hint $user as the User model (e.g., User), $flight as Flight,
$aircraft as Aircraft, and $fares as the correct collection/array type (e.g.,
array or Collection) while keeping the existing ?SimBrief return type; also
import or fully-qualify these classes at the top of the test file so the
downloadOfp function and its calls compile and follow the project's typing
guidelines.

---

175-177: Remove duplicated assertion in the expectation chain.

The same non-null simbrief.id assertion is repeated twice; keeping one is enough and improves readability.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Feature/SimBriefTest.php` around lines 175 - 177, The expectation chain
in the test duplicates the same assertion for
expect($body['flight']['simbrief']['id']) twice; edit the test (SimBriefTest) to
remove the duplicated ->and($body['flight']['simbrief']['id'])->not->toBeNull()
so the chain only asserts simbrief.id once and still includes the subsequent
->and($body['flight']['simbrief']['subfleet']['fares'])->not->toBeNull().

---

131-134: Remove commented-out assertion block.

Keeping disabled assertions in-place makes maintenance harder and obscures the real checks.

As per coding guidelines: "Prefer PHPDoc blocks over inline comments; never use comments within the code itself unless the logic is exceptionally complex".

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Feature/SimBriefTest.php` around lines 131 - 134, In the SimBriefTest
test, remove the commented-out assertion block containing
$this->assertEquals('https://localhost/api/flights/'.$briefing->id.'/briefing',
$url); — delete those commented lines (the disabled $this->assertEquals
reference to $briefing->id and $url) so the test contains only active assertions
or, if an assertion is still required, replace the commented block with an
active $this->assertEquals(...) using $briefing->id and $url in the appropriate
test method.