Add information about assignees, reviewers, and approvers to body #232
Conversation
src/githubHelper.ts
Outdated
| this.gitlabHelper | ||
| ); | ||
|
|
||
| if (add_issue_information) { |
There was a problem hiding this comment.
Would it be better to put this behind a setting?
src/gitlabHelper.ts
Outdated
| }, | ||
| ); | ||
| console.log(approvals); | ||
| console.log(approvals.rules[0]); |
There was a problem hiding this comment.
Are these logging statements left from development or do they server a purpose?
There was a problem hiding this comment.
My bad, leftovers from development.
src/githubHelper.ts
Outdated
| let mrAssignees = issue.assignees.map(a => a.username); | ||
| if (settings.usermap) { | ||
| let assignees = []; | ||
| for (let assignee of mrAssignees) { | ||
| let githubUser = settings.usermap[assignee as string]; | ||
| if (githubUser) { | ||
| githubUser = '@' + githubUser; | ||
| } else { | ||
| githubUser = assignee as string; | ||
| } | ||
| assignees.push(githubUser); | ||
| } | ||
|
|
||
| if (assignees.length > 0) { | ||
| bodyConverted += '\n\n**Assignees:** ' + assignees.join(', '); | ||
| } | ||
| } |
There was a problem hiding this comment.
Could you refactor this into a function which gets called with assignees, reviewers and approvals as it seems they are nearly the same
There was a problem hiding this comment.
Good point! Moved it into a util function. If you have an idea for a better name for the function, let me know.
| item: GitLabIssue | GitLabMergeRequest | GitLabNote | MilestoneImport, | ||
| add_line: boolean = true | ||
| add_line: boolean = true, | ||
| add_line_ref: boolean = true, |
There was a problem hiding this comment.
My bad, I accidentally copied this change over from my own branch that contains all improvements in one. It belongs to #210. Now that that one is merged and this one up to date it is fixed.
src/githubHelper.ts
Outdated
| this.gitlabHelper | ||
| ); | ||
|
|
||
| if (add_issue_information) { |
0790a07 to
83a7567
Compare
|
Thanks for the work 👍 |
Information about assignees and reviewers (and whether they approved) can get lost when migrating, especially if the users don't exist on GitHub, or are not part of the same organization (anymore).
This PR adds assignees (issue and MR), reviewers (MR only), and approvals (MR only) to the end of the body of a migrated merge request (just above the "Migrated from ..." line).