Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use correct endpoint for determining MR approvals #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025
Merged

Use correct endpoint for determining MR approvals #237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/gitlabHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,24 +151,24 @@ export class GitlabHelper {
return this.allBranches as any[];
}

async getMergeRequestApprovals(pullRequestIid: number): Promise<string[]> {
async getMergeRequestApprovals(mergeRequestIid: number): Promise<string[]> {
try {
let approvals = await this.gitlabApi.MergeRequestApprovals.showConfiguration(
let approvals = await this.gitlabApi.MergeRequestApprovals.configuration(
this.gitlabProjectId,
{
mergerequestIId: pullRequestIid,
mergerequestIid: mergeRequestIid,
},
);

if (approvals.rules[0]) {
return approvals.rules[0].approved_by.map(user => user.username);
if (approvals.approved_by) {
return approvals.approved_by.map(user => user.user.username);
}

console.log(`No approvals found for GitLab merge request !${pullRequestIid}.`)
console.log(`No approvals found for GitLab merge request !${mergeRequestIid}.`)
} catch (err) {
console.error(
`Could not fetch approvals for GitLab merge request !${pullRequestIid}: ${err}`
`Could not fetch approvals for GitLab merge request !${mergeRequestIid}: ${err}`
);
throw err;
}
return [];
}
Expand Down