Remove (outdated) recipe implementation of Kernel::configureContainer() and ::configureRoutes() methods
#14657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review Checklist
|
dvesh3
approved these changes
Mar 23, 2023
|
@jdreesen thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pimcore still uses the Symfony 5.2
Kernelrecipe, which changed a bit in Symfony 5.3 and was integrated into theMicroKernelTraitin Symfony 5.4 via symfony/symfony#42991.Since Pimcore 11 only supports Symonfy 6 as a minimum, we can rely on the default implementation (which also has the advantage that it allows PHP config by default, which is the new preferred way of Symfony).
Please note that this is a breaking change as
MicroKernelTrait::configureContainer()has three parameters instead of one.