Various fixes & improvements #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix regression raised in #33.
Member
Author
|
For users wanting to use multiple ST7789 boards, and who have found it's all suddenly rather broken, this is a "The Linux Kernel No Longer Lets You Share Pins" problem. Fortunately we don't strictly need to share pins. Using this branch it should be possible to pass in a pin object, in lieu of an int, and the ST7789 library will use that. I still need to whip up an example, but I stuck some ✨ Factory Functions ✨ onto ST7789 so you can share the same data/command pin like so: dc = st7789.ST7789.get_dc_pin(pin)
display1 = st7789.ST7789(... dc=dc ...)
display2 = st7789.ST7789(... dc=dc ...)I hasten to add that I need to dig up my breakouts and Breakout Garden and actually test these changes. |
Allow the same pin instance to be passed into multiple driver instances. Fixes #34.
d00b9a9 to
aba5f1f
Compare
c0dcb1f to
9aabd78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Round up of a few overdue fixes and quality of life improvements.
I've added some comments to the examples that should save future Pirate Audio users a little hassle. Thanks to Floyd for finally poking me to connect the dots. Watch his Fluid Synth build video here: https://www.youtube.com/watch?v=ilmhX1j-ENU