Thanks to visit codestin.com
Credit goes to github.com

Skip to content

dumpling: precheck log file permisssion (#61101)#61102

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-8.5from
ti-chi-bot:cherry-pick-61101-to-release-8.5
May 15, 2025
Merged

dumpling: precheck log file permisssion (#61101)#61102
ti-chi-bot[bot] merged 2 commits intopingcap:release-8.5from
ti-chi-bot:cherry-pick-61101-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented May 14, 2025

This is an automated cherry-pick of #61101

What problem does this PR solve?

Issue Number: close #61100
ref pingcap/log#43

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added component/dumpling This is related to Dumpling of TiDB. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels May 14, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request May 14, 2025
Merged
13 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented May 14, 2025

@GMHDBJD This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

GMHDBJD
GMHDBJD approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 14, 2025
@codecov
Copy link

codecov bot commented May 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.5@b957a04). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-8.5     #61102   +/-   ##
================================================
  Coverage               ?   76.4611%           
================================================
  Files                  ?       1642           
  Lines                  ?     450124           
  Branches               ?          0           
================================================
  Hits                   ?     344170           
  Misses                 ?      85066           
  Partials               ?      20888
Flag Coverage Δ
integration 48.6894% <ø> (?)
unit 72.6898% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9278% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.3098% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GMHDBJD
Copy link
Contributor

GMHDBJD commented May 14, 2025

/retest

@Benjamin2037 Benjamin2037 added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels May 14, 2025
Benjamin2037
Benjamin2037 approved these changes May 14, 2025
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, GMHDBJD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 14, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 14, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-14 05:53:30.986476544 +0000 UTC m=+510877.134437764: ☑️ agreed by GMHDBJD.
  • 2025-05-14 06:23:41.254404343 +0000 UTC m=+512687.402365561: ☑️ agreed by Benjamin2037.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 14, 2025
@GMHDBJD GMHDBJD removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2025
@GMHDBJD
Copy link
Contributor

GMHDBJD commented May 15, 2025

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 15, 2025

@GMHDBJD: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit b992ca8 into pingcap:release-8.5 May 15, 2025
22 checks passed
@ti-chi-bot ti-chi-bot bot removed the cherry-pick-approved Cherry pick PR approved by release team. label May 15, 2025
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. labels May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees

@GMHDBJD GMHDBJD

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. component/dumpling This is related to Dumpling of TiDB. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @GMHDBJD @Benjamin2037