feat: add diff view when transpiling query #1010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jczhong84
reviewed
Sep 19, 2022
querybook/webapp/components/TranspileQueryModal/TranspileQueryModal.tsx
Outdated
Show resolved
Hide resolved
| const [addedRanges, removedRanges] = useMemo(() => { | ||
| const added: IHighlightRange[] = []; | ||
| const removed: IHighlightRange[] = []; | ||
| const diffObjects = diffWordsWithSpace(fromQuery, toQuery); |
There was a problem hiding this comment.
do we want to do diffLines instead?
also is it easy to add empty rows if one side has few lines than the other? so the line numbers will match
There was a problem hiding this comment.
maybe codemirror 6, it is kind of a hassle to use MergeView right now
There was a problem hiding this comment.
i tried diffLines, but there is too much detail missing
querybook/webapp/components/TranspileQueryModal/TranspileQueryModal.tsx
Outdated
Show resolved
Hide resolved
jczhong84
approved these changes
Sep 19, 2022
lilyli9
pushed a commit
to lilyli9/querybook
that referenced
this pull request
Jan 26, 2023
## [0.22.0](https://github.expedia.biz/eg-analytics-platform/querybook/compare/0.21.1...0.22.0) (2022-09-20) ### Features * add diff view when transpiling query (pinterest#1010) ([225b0ac](https://github.expedia.biz/eg-analytics-platform/querybook/commit/225b0ac20717cd7bad2196387f34e891896003f5)) ### Bug Fixes * automatic serialize sqlalchemy Row (pinterest#1011) ([372ab25](https://github.expedia.biz/eg-analytics-platform/querybook/commit/372ab25436cd0dd7b0846d7545b3255dbe5876c9)) * table validation for sync_table (pinterest#1008) ([760b6ec](https://github.expedia.biz/eg-analytics-platform/querybook/commit/760b6ec0dd3715058b138b528657cc62558d27a5))
rohan-sh1
pushed a commit
to CAI-TECHNOLOGIES/cai-ext-db-explorer
that referenced
this pull request
Feb 28, 2023
* feat: add diff view when transpiling query * comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a comparison view before user confirm