fix: do not transform presto map keys #1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@froukees FYI, let us know if you have alternative suggestions |
jczhong84
approved these changes
Sep 27, 2022
lilyli9
pushed a commit
to lilyli9/querybook
that referenced
this pull request
Jan 26, 2023
## [0.26.0](https://github.expedia.biz/eg-analytics-platform/querybook/compare/0.25.0...0.26.0) (2022-09-27) ### Features * (experimental) make error suggestion pluggable (pinterest#1017) ([3a5eb97](https://github.expedia.biz/eg-analytics-platform/querybook/commit/3a5eb97a26a7bcbb419144a34dda78a5b2c52cea)) * Merge branch 'upstream' ([00ac4cf](https://github.expedia.biz/eg-analytics-platform/querybook/commit/00ac4cfc0875da8a4912fd63bb0d100b764b5ce0)) * show deactivated user with different ui (pinterest#1014) ([3fd594f](https://github.expedia.biz/eg-analytics-platform/querybook/commit/3fd594fbfb0567f3adc29272a5c11ca38d9673b3)) ### Bug Fixes * do not transform presto map keys (pinterest#1021) ([bd73970](https://github.expedia.biz/eg-analytics-platform/querybook/commit/bd73970e9f37d73584da7f37a123488d5ff849c8)) * JSONView fix (pinterest#1019) ([0b810c2](https://github.expedia.biz/eg-analytics-platform/querybook/commit/0b810c2f0a991c7c896ed54672db1be1ba0f8cd6)) * userInfo might be null (pinterest#1016) ([ca2f1bc](https://github.expedia.biz/eg-analytics-platform/querybook/commit/ca2f1bc8ea32f14729d2f4c73980172c9a19ddc9))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #991
example query that fails:
The reason is that MAP is converted to Python dict, but Python dict cannot have keys with type
list(which is what ARRAY gets translated to).When Presto output rows in JSON, the keys are already serialized to strings, which means they are not parsable anyway, in this case, we just do not translate the keys at all.
Also added testing