fix: table column auto completion not work sometimes #1026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgu
reviewed
Oct 4, 2022
czgu
reviewed
Oct 5, 2022
| return; | ||
| } | ||
|
|
||
| const warnings = await getLintErrors(code, editor); |
There was a problem hiding this comment.
getLintErrors might be undefined
There was a problem hiding this comment.
there is a check on !getLintErrors above
| const { dataTableNameToId, dataTablesById, dataTableWarningById } = | ||
| reduxStore.getState().dataSources; | ||
| for (const table of allTables) { | ||
| for (const table of tableReferences) { |
There was a problem hiding this comment.
don't provide Table ${table.name} is newly created or does not exist warning if getLintErrors is defined
czgu
approved these changes
Oct 5, 2022
czgu
approved these changes
Oct 5, 2022
czgu
added a commit
that referenced
this pull request
Oct 24, 2022
* fix: disable json parsing by default (#1025) * fix: schedule owner not update (#1027) * fix: Replace cronjs-matcher with cron-parser (#1028) * fix: disable autocomplete for exact matches (#1029) * fix: Increase CodeMirror hint z-index above modals (#1030) Fixes the QueryEditor's autocomplete on the Snippet editor modal, which has a z-index of 300. * fix: table column auto completion not work sometimes (#1026) * fix: table column auto comletion not work sometimes * prefetch all tables * remove unused imports * use getTableByName * add back table warning annotations * remove return await * ignore table not exist warnings * use await * feat: add formatted transpile view (#1031) * fix: ExecutedQueryCell auto scropll to top during execution (#1033) * refactor: QueryEditor to functional component (#1032) * refactor: QueryEditor to functional component * update format options type * fix linter warnings * useMemo * docs: add instruction on init_db (#1034) * docs: add instruction on init_db * comment * fix: query editor issues after refactor (#1035) * feat: Add syntax highlight/copy to markdown code (#1039) * feat: Add syntax highlight/copy to markdown code * remove extra space * add jinja2, python, sh support to templating * feat: syntax highlighting for templated queries (#1040) * feat: syntax highlighting for templated queries * remove comment * fix test * fix: codemirror starts with a wrong height (#1041) * fix: formatQuery isn't using the latest ref (#1042) * ui: keep the search string when switching the search type (#1043) * ui: keep the search string when switching the search type * comment * fix: QueryComposer additional buttons nested right (#1044) Fixes issues with the Transpile Query submenu appearing under the sidebar * fix: template variable type change and big numbers (#1046) * fix: variable type change * show error for big numbers * remove unused vars * move to helper.ts * fix: Update Google OAuth Version (#1057) * test: dummy PR to test if pytest pass * test * update workflow * bump version to latest * fix test * bump version * added space back * feat: dag exporter ui update (#1024) * feat: dag exporter ui update * update yarn.lock * address comments * feat: update base and demo dag exporter (#1038) * feat: add query engine validation for dag exporter (#1045) #1045 * Revert "rebase master onto dag-v2 (#1047)" (#1049) This reverts commit 792376e. * address comments from PR 1045 (#1051) * address comments of PR 1045 * add type * nullable * ui: update dag exporter (#1050) #1050 * Revert "ui: update dag exporter (#1050)" (#1055) This reverts commit 793c08b. * ui update #1056 Co-authored-by: J.C. Zhong <[email protected]> Co-authored-by: Dave Bauman <[email protected]> Co-authored-by: czgu <[email protected]> Co-authored-by: J.C. Zhong <[email protected]>
lilyli9
pushed a commit
to lilyli9/querybook
that referenced
this pull request
Jan 26, 2023
## [0.30.0](https://github.expedia.biz/eg-analytics-platform/querybook/compare/0.29.1...0.30.0) (2022-10-18) ### Features * add formatted transpile view (pinterest#1031) ([b5120ed](https://github.expedia.biz/eg-analytics-platform/querybook/commit/b5120edb82250c71a9f1a2bf9ff0663da462d93a)) * Add syntax highlight/copy to markdown code (pinterest#1039) ([c78fd7f](https://github.expedia.biz/eg-analytics-platform/querybook/commit/c78fd7f18d93ce753665426ec4e92fe149a2d147)) * Merge branch 'upstream' ([c84b843](https://github.expedia.biz/eg-analytics-platform/querybook/commit/c84b843d17103993c67b483be6a3a2cb4ecce7e1)) * syntax highlighting for templated queries (pinterest#1040) ([12346ea](https://github.expedia.biz/eg-analytics-platform/querybook/commit/12346ea0ed93e5f9890ee5e453eacf9690f0eaa6)) ### Bug Fixes * codemirror starts with a wrong height (pinterest#1041) ([a2d7463](https://github.expedia.biz/eg-analytics-platform/querybook/commit/a2d746364478016badc769be470da8d556fb8dd8)) * ExecutedQueryCell auto scropll to top during execution (pinterest#1033) ([011bb92](https://github.expedia.biz/eg-analytics-platform/querybook/commit/011bb92435dd6d59a85afb57041fecbdd548f096)) * formatQuery isn't using the latest ref (pinterest#1042) ([7f02f09](https://github.expedia.biz/eg-analytics-platform/querybook/commit/7f02f0993cfba4756731e559d3b4fddd0204043f)) * query editor issues after refactor (pinterest#1035) ([3faf4bb](https://github.expedia.biz/eg-analytics-platform/querybook/commit/3faf4bb7e588b6ed76c5aa1eafaf9f81827859fd)) * table column auto completion not work sometimes (pinterest#1026) ([72bd343](https://github.expedia.biz/eg-analytics-platform/querybook/commit/72bd343dd5b39fee8fa4d093069d839167539b9f))
rohan-sh1
pushed a commit
to CAI-TECHNOLOGIES/cai-ext-db-explorer
that referenced
this pull request
Feb 28, 2023
* fix: table column auto comletion not work sometimes * prefetch all tables * remove unused imports * use getTableByName * add back table warning annotations * remove return await * ignore table not exist warnings * use await
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the client side never fetch the data table before, the column auto completion wont work. This change is to prefetch all the tables in the query no matter user picked it from auto completion list or typed themselves.