Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

baumandm
Copy link
Contributor

@baumandm baumandm commented Nov 4, 2022

We use lots of long struct types, which cause some display problems. This PR includes two fixes:

  1. In the table sidebar, long types are truncated, since users can click to view the full type in the ColumnPanelView:

Screen Shot 2022-11-04 at 9 48 40 AM Screen Shot 2022-11-04 at 9 48 47 AM

  1. In the Column tab of the table view, long types are wrapped so the entire contents can be veiwed:

Screen Shot 2022-11-04 at 9 49 13 AM Screen Shot 2022-11-04 at 10 46 39 AM

@czgu czgu merged commit 0cbbb42 into pinterest:master Nov 8, 2022
@baumandm baumandm deleted the feat/long-types branch November 10, 2022 15:40
rohan-sh1 pushed a commit to CAI-TECHNOLOGIES/cai-ext-db-explorer that referenced this pull request Feb 28, 2023
* fix: Truncate long column types in Table sidebar view

* fix: Wrap long column types in column tab of the Table view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants