refactor: reduce component re-render #446
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly addresses #433
Benchmark:
Test 1
Large datadoc with ~30 query cells. Ensure they are all rendered and start typing in 1 cell with keystrokes of 5hz. Measured using React profiler:
worst case render time:
Before ~150ms
After: ~6ms
Test 2
Fully rendered the said doc above, click on the first four cells sequentially:
worse case render time:
before: ~160ms
after: ~11ms