feat: support progressPercentage in hive thrift response #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgu
requested changes
Jun 8, 2021
querybook/tests/test_lib/test_query_executor/test_hive_progress_percentage.py
Outdated
Show resolved
Hide resolved
|
Thanks for contributing! added some minor comments |
added 4 commits
June 8, 2021 14:16
czgu
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #552
Just added a check if progressPercentage is reported by thrift response. If yes, Hive Client uses it to calculate percentage. It falls back on original method of calculating based on map/reduce progress. Added unit tests.