Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

yongchand
Copy link
Contributor

  1. Without initdb and initweb options, web will not start properly and cannot start db.
  2. LoadBalancer is unnecessary, we can use ClusterIP
  3. OOM will occur with current limit

All these commits have been tested already through my own k8s cluster.

Copy link
Collaborator

@czgu czgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Just curious, for the OOM error, are they caused by the web container or the worker container? Currently the prod web containers at Pinterest uses ~300MBs of memory

@yongchand
Copy link
Contributor Author

Thanks for the contribution! Just curious, for the OOM error, are they caused by the web container or the worker container? Currently the prod web containers at Pinterest uses ~300MBs of memory

It was caused by both web container and worker container for my case. I may double check, but increasing limit seems valid to me since I wont change request. What's your opinion about this?

@czgu
Copy link
Collaborator

czgu commented Jun 23, 2021

Thanks for the contribution! Just curious, for the OOM error, are they caused by the web container or the worker container? Currently the prod web containers at Pinterest uses ~300MBs of memory

It was caused by both web container and worker container for my case. I may double check, but increasing limit seems valid to me since I wont change request. What's your opinion about this?

Got it, I think given what you have mentioned, its fine to increase the memory limit. 👍

@yongchand
Copy link
Contributor Author

@czgu Found out it works well without initweb! Thank you :)

Copy link
Collaborator

@czgu czgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@czgu czgu merged commit 34f7a20 into pinterest:master Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants