Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

czgu
Copy link
Collaborator

@czgu czgu commented Aug 20, 2021

Overview of changes

  • Now any API calls in Querybook will have strongly typed input/output values.
  • This should also make updating API easier as there is now only 1 entrypoint to the API itself.
  • API endpoints are now grouped by resource names, making them easier to find
  • useDataFetch is now useResource, the hook became simpler as it only needs to memo the function.

Minor logic changes:

  • swap query engine now return null
  • removed unused task_type variable from /schedule/int:id/record/
  • fixed a bug where form does not close when creating warnings
  • Removed default return type = any for API calls, now it would return unknown if not specified
  • fixed an issue where download csv would not work for localhost:port

Tests:
Manually verified APIs to work locally, typing and linting should also have no exception cases as well

@czgu czgu requested a review from meowcodes August 20, 2021 22:01
@czgu czgu merged commit 4e1aed2 into pinterest:master Aug 20, 2021
@czgu czgu deleted the resources branch August 20, 2021 22:53
rohan-sh1 pushed a commit to CAI-TECHNOLOGIES/cai-ext-db-explorer that referenced this pull request Feb 28, 2023
* temp

* refactor: Use resource for api calls

* fix linter

* fix lint again

* Added some missing typings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants