Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Add option to filter tables by query engines #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 25, 2021
Merged

feat: Add option to filter tables by query engines #642

merged 4 commits into from
Aug 25, 2021

Conversation

kgopal492
Copy link
Contributor

@kgopal492 kgopal492 commented Aug 24, 2021 •
edited
Loading

closes #222

  • Add query engine filters to query examples tab in table view
  • Add query engines to overview tab in table view if there's more than 1 engine

Query Examples Tab

Query engines filters shown

Screen Shot 2021-08-24 at 1 19 55 PM

No query UI

Screen Shot 2021-08-24 at 2 13 16 PM

Overview Page

Query engine filters shown

Screen Shot 2021-08-24 at 1 20 06 PM

Query engines hidden when there's only 1 query engine

Screen Shot 2021-08-24 at 1 20 36 PM

@kgopal492 kgopal492 requested a review from czgu August 24, 2021 00:40
@github-actions github-actions bot added the title needs formatting PR title must have type (ex. fix:) label Aug 24, 2021
@kgopal492 kgopal492 changed the title Add option to filter tables by query engines Fix: Add option to filter tables by query engines Aug 24, 2021
@kgopal492 kgopal492 changed the title Fix: Add option to filter tables by query engines fix: Add option to filter tables by query engines Aug 24, 2021
@github-actions github-actions bot removed the title needs formatting PR title must have type (ex. fix:) label Aug 24, 2021
@kgopal492 kgopal492 changed the title fix: Add option to filter tables by query engines feat: Add option to filter tables by query engines Aug 24, 2021
czgu
czgu reviewed Aug 25, 2021
View reviewed changes
@czgu czgu merged commit df6b93b into master Aug 25, 2021
@czgu czgu deleted the filter-engines branch August 25, 2021 19:48
rohan-sh1 pushed a commit to CAI-TECHNOLOGIES/cai-ext-db-explorer that referenced this pull request Feb 28, 2023
@kgopal492
feat: Add option to filter tables by query engines (pinterest#642)
87f2d29 
* Add option to filter tables by query engines

* remove limit from query engines

* hide query engines from overview page when there's only 1 engine

* Address PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czgu czgu czgu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter example queries by query engine
2 participants
@kgopal492 @czgu