Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support signature v4 enabled buckets as result store #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2021
Merged

Support signature v4 enabled buckets as result store #661

merged 2 commits into from
Sep 28, 2021

Conversation

Aka-shi
Copy link

@Aka-shi Aka-shi commented Sep 24, 2021

No description provided.

czgu
czgu reviewed Sep 26, 2021
View reviewed changes
Copy link
Collaborator

@czgu czgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a bit of documentation to add_result_store.md to cover the usage? Just some quick notes are good enough 👍

czgu
czgu reviewed Sep 27, 2021
View reviewed changes
Copy link
Collaborator

@czgu czgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the documentation :)

@czgu czgu merged commit cab17cc into pinterest:master Sep 28, 2021
@Aka-shi Aka-shi deleted the s3_signature branch September 28, 2021 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czgu czgu czgu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aka-shi @czgu