Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Improve sample queries #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 7, 2021
Merged

feat: Improve sample queries #676

merged 8 commits into from
Oct 7, 2021

Conversation

czgu
Copy link
Collaborator

@czgu czgu commented Oct 7, 2021 •
edited
Loading

  • Added more comparison types: >, >=, <, <=
  • Added the ability to have multiple where clauses
    image
  • Added error message when sample query fails
    image

@czgu czgu requested a review from meowcodes October 7, 2021 02:20
@czgu czgu merged commit 3c8c34e into pinterest:master Oct 7, 2021
@czgu czgu deleted the uid2 branch March 15, 2022 17:40
rohan-sh1 pushed a commit to CAI-TECHNOLOGIES/cai-ext-db-explorer that referenced this pull request Feb 28, 2023
@czgu
feat: Improve sample queries (pinterest#676)
d126f6e 
* feat: Improve sample queries

* fix tests

* remove hidden space in test

* add better error message when task fails, and show for both view and generate query

* Add new components

* Adjust margin

* fix return type

* fix return type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@meowcodes meowcodes meowcodes approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czgu @meowcodes