Feat : Trino plugin Integration - Querybook #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aka-shi
reviewed
Oct 25, 2021
czgu
reviewed
Oct 25, 2021
Aka-shi
reviewed
Oct 27, 2021
querybook/server/lib/query_executor/executor_template/templates.py
Outdated
Show resolved
Hide resolved
querybook/server/lib/query_executor/executor_template/templates.py
Outdated
Show resolved
Hide resolved
querybook/server/lib/query_executor/executor_template/templates.py
Outdated
Show resolved
Hide resolved
czgu
reviewed
Nov 2, 2021
There was a problem hiding this comment.
PR looks good to me! Just some minor linting fix thats needed.
Besides the requirements/base.txt issue, can you also update the documentation of https://www.querybook.org/docs/setup_guide/connect_to_query_engines#overview to have Trino as Tier 2 (we can move to Tier 1 later if it works well) and change the package to trino instead of sqlalchemy-trino?
|
Actually, nvm about the requirements/base.txt change. Just note that it will be removed in requirements/base.txt in 3.0 |
3653de4 to
c100b3a
Compare
czgu
approved these changes
Nov 8, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrating an official Trino Plugin for query book backed-up with native Trino-python-client.
Issue Link : #509