Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Feat: Enable embedding of datadocs #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 16, 2022
Merged

Feat: Enable embedding of datadocs #747

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
4d1924f
Add endpoint for embeddable DataDocs
darapuk Feb 19, 2022
ad4d3a0
remove CSS
darapuk Feb 19, 2022
025a0c9
CSS is used to enable scrolling
darapuk Feb 19, 2022
a01f08b
remove un-needed params
darapuk Feb 19, 2022
9d560a5
remove unneeded CSS
darapuk Feb 19, 2022
bd7f269
lint
darapuk Feb 19, 2022
964cef6
add type hints
darapuk Feb 19, 2022
8f84f62
PR feedback
darapuk Feb 22, 2022
2ba4349
lint
darapuk Feb 22, 2022
67ffb9e
Merge branch 'master' into kartik/add_ability_to_embed_datadocs
darapuk Mar 15, 2022
8e80cee
cleanup collapsing logic & Add story
darapuk Mar 16, 2022
b25874a
lint
darapuk Mar 16, 2022
e2bb9c5
refactor to remove embedding from AppSidebar to envCollapsed reducer
darapuk Mar 16, 2022
f1a25dd
lint
darapuk Mar 16, 2022
636a733
PR feedback
darapuk Mar 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unneeded CSS
  • Loading branch information
@darapuk
darapuk committed Feb 19, 2022
commit 9d560a59299761efac5579eb609f91f202df163c
5 changes: 0 additions & 5 deletions querybook/webapp/components/EmbeddedDataDocPage/EmbeddedDataDocPage.scss
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions querybook/webapp/components/EmbeddedDataDocPage/EmbeddedDataDocPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
import React from 'react';
import { FullHeight } from 'ui/FullHeight/FullHeight';
import './EmbeddedDataDocPage.scss';
import { DataDoc } from 'components/DataDoc/DataDoc';

const EmbeddedDataDocPage: React.FunctionComponent = ({id}) => {
return (
<FullHeight flex={'column'} className="EmbeddedDataDocPage">
<div className="datadoc-wrapper">
<div>
<DataDoc docId={id} />
</div>
</FullHeight>
Expand Down