feat: make statement result export async #777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgu
reviewed
Mar 17, 2022
querybook/webapp/components/DataDocStatementExecutionBar/ResultExportSuccessToast.tsx
Show resolved
Hide resolved
czgu
reviewed
Mar 18, 2022
querybook/tests/test_lib/test_export/test_exporters/test_gspread_exporter.py
Outdated
Show resolved
Hide resolved
querybook/webapp/components/DataDocStatementExecutionBar/ResultExportDropdown.tsx
Outdated
Show resolved
Hide resolved
querybook/webapp/components/DataDocStatementExecutionBar/ResultExportDropdown.tsx
Outdated
Show resolved
Hide resolved
czgu
previously approved these changes
Mar 18, 2022
czgu
approved these changes
Mar 22, 2022
rohan-sh1
pushed a commit
to CAI-TECHNOLOGIES/cai-ext-db-explorer
that referenced
this pull request
Feb 28, 2023
* feat: make statement result export async * Update to read past ChunkReader limit, implement get_csv_iter in BaseReader, add testss * feat: make statement result export async * Update to read past ChunkReader limit, implement get_csv_iter in BaseReader, add testss * Address PR comments * Fix more PR style comments * fix last pr comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #203
Make export async
Allow entire statement results to be exported to exporters (up to exporter limits)
get_csv_iteras an abstract method inBaseReaderto read query results in batchesread_csvmethod inBaseReadernow unpacks results fromget_csv_itergspread_exporteris updated to suppport reading entire results pastSTORE_MAX_READ_SIZE(up to gspread limit)