fix: restrict access to private queries in query search #875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgu
reviewed
May 26, 2022
|
|
||
|
|
||
| def _get_partial_dict(field_to_generator, fields=None): | ||
| if fields is None: |
There was a problem hiding this comment.
fields = fields or field_to_generator.keys()
return {field: field_to_generator[field]() for field in fields if field in field_to_generator} There was a problem hiding this comment.
Slightly changed to the following to check whether getter is a callable or value:
fields = fields or field_to_getter.keys()
return {
field: getter() if callable(getter) else getter
for field, getter in field_to_getter.items()
if field in fields
}
There was a problem hiding this comment.
super minor, but
for field, getter in field_to_getter.items()
if field in fields
is n^2, so its faster to check if field in field_to_getter
There was a problem hiding this comment.
ooh good point, fixed that!
querybook/tests/test_lib/test_elasticsearch/test_elasticsearch.py
Outdated
Show resolved
Hide resolved
czgu
previously approved these changes
May 27, 2022
czgu
previously approved these changes
May 27, 2022
czgu
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #865
publicandreadable_user_idsfields to query_cell and query_execution elasticsearch indices to restrict access to queries on private datadocsquerybook/server/datasources/search.pyto use "must" query to ensure user has access to datadocs & queries that are returned