Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: improve charting axis and value display #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 12, 2022
Merged

feat: improve charting axis and value display #999

merged 2 commits into from
Sep 12, 2022

Conversation

czgu
Copy link
Collaborator

@czgu czgu commented Sep 12, 2022 •
edited
Loading

  • Update chart.js to latest
  • Added option to format axis with either $ or %
  • also semi reverted the changes in Bugfix: scatter/bubble charts were losing their labels after save #985. Instead of using the first column as value (for scatter). Added option to either use "series" name or y value for label
  • fix: query transpilation doesn't save to backend
  • updated run button length (back to 120px), shrunk the ... button

@czgu czgu marked this pull request as ready for review September 12, 2022 17:59
@czgu czgu merged commit 3b36df2 into pinterest:master Sep 12, 2022
@czgu czgu deleted the fix branch September 12, 2022 20:41
lilyli9 pushed a commit to lilyli9/querybook that referenced this pull request Jan 26, 2023
chore(release): 0.21.0 [skip ci]
a0385e4 
## [0.21.0](https://github.expedia.biz/eg-analytics-platform/querybook/compare/0.20.3...0.21.0) (2022-09-15)

### Features

* Add a new function to sync table with metastore (pinterest#998) ([6ffe0ff](https://github.expedia.biz/eg-analytics-platform/querybook/commit/6ffe0ff48d99045f0b73b1831978b0b752d8e940))
* allow user to bypass LIMIT (pinterest#1000) ([e9d11ed](https://github.expedia.biz/eg-analytics-platform/querybook/commit/e9d11edc8c8a96102ab2d7d9487f95c669c22a82))
* improve charting axis and value display (pinterest#999) ([3b36df2](https://github.expedia.biz/eg-analytics-platform/querybook/commit/3b36df2bd9aaa4874715a3754824a458c08e9e6f))
* improved query limit (pinterest#995) ([64f6e60](https://github.expedia.biz/eg-analytics-platform/querybook/commit/64f6e60ef0517a4c6f315882d94bc088bdaa4842))
* Merge branch 'upstream/master' ([88abf71](https://github.expedia.biz/eg-analytics-platform/querybook/commit/88abf71f93301c09ea80af8412d95c3b877cfc8d))
* pass execution type to executor client (pinterest#992) ([5f3a961](https://github.expedia.biz/eg-analytics-platform/querybook/commit/5f3a9613aabbcc8f9eb47d5e197ff41f1dd55915))
* show 404 page when table gets deleted (pinterest#1003) ([37a9434](https://github.expedia.biz/eg-analytics-platform/querybook/commit/37a94345884f934ab9c7d11a4ae088b4ecafdb63))

### Bug Fixes

* add acl check for metastore table sync (pinterest#1004) ([fdb5df0](https://github.expedia.biz/eg-analytics-platform/querybook/commit/fdb5df09480d9c0beb2f1ef38d755dae5c55ab96))
* disable new features in read only mode (pinterest#1002) ([5fa45d7](https://github.expedia.biz/eg-analytics-platform/querybook/commit/5fa45d7e292ecf34dd3260f23bc468eed3fa7e83))
* Hide export option on scheduler pop-up if there are no exporters available (pinterest#1001) ([d8a3112](https://github.expedia.biz/eg-analytics-platform/querybook/commit/d8a31125e4700b1acb4d7f5349e202786db32f0f))
* lint error doesn't disappear when switching to templating query (pinterest#994) ([a859d7a](https://github.expedia.biz/eg-analytics-platform/querybook/commit/a859d7a267e3ea7bb187d4c771b4aff81609a5c5))
* raise rate limit for the sync api (pinterest#1007) ([0251ffd](https://github.expedia.biz/eg-analytics-platform/querybook/commit/0251ffdd23cd25ab8ee5003f47926848d15a802e))
* transfer schedule's ownership along with datadoc's ownership (pinterest#1005) ([8732d97](https://github.expedia.biz/eg-analytics-platform/querybook/commit/8732d9793ad6d3dbdd809bb23dea9535c7842acf))
rohan-sh1 pushed a commit to CAI-TECHNOLOGIES/cai-ext-db-explorer that referenced this pull request Feb 28, 2023
@czgu
feat: improve charting axis and value display (pinterest#999)
3823cc5 
* feat: improve charting axis and value display

* rebase, updated run button length
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jczhong84 jczhong84 jczhong84 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czgu @jczhong84